This differential creates large notifications in thick threads
Details
Details
- Reviewers
kamil tomek - Commits
- rCOMM51312a1e05f8: Create large notifications in thick threads
Tested in final diff
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/eng-8709
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/push/send-utils.js | ||
|---|---|---|
| 505 | I must have forgotten to update this diff. This code is no longer there | |
| 793 | It is not going to work with eslint since largeNotifDataArray is already declared in the upper scope | |
| 816 | buildNotifsForPlatform expects a function that returns {
+targetedNotificationsWithPlatform: $ReadOnlyArray<TargetedNotificationWithPlatform>,
+largeNotifDataArray?: ...
}but function that create badge updates and rescinds return only targetedNotificationsWithPlatform. Making the type here inexact solves flow complaint. | |