account deletion should fail if we can't delete data from other services. we should also attempt to delete this data first so that if we're unable to, the user is still able to call the delete RPCs on identity.
Details
Details
temporarily disabled tunnelbroker and called delete_wallet_user. it failed, as expected. enabled tunnelbroker again and delete_wallet_user succeeded
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- delete
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/identity/src/grpc_services/authenticated.rs | ||
|---|---|---|
| 626 | You can also remove the let device_ids = [...[].get_current_device_list(&user_id) call inside delete_user() and make it return Result<()>. | |
| services/identity/src/grpc_services/authenticated.rs | ||
|---|---|---|
| 626 | Never mind, didn't notice the next diff | |
| services/identity/src/grpc_services/authenticated.rs | ||
|---|---|---|
| 99 | I kept this function because I think it's fine if we spawn a new task for tunnelbroker data deletion during the logout workflows | |