Page MenuHomePhabricator
Differential D13575

[web] send OTKs on v1 login
Needs ReviewPublic
Actions

Authored by varun on Wed, Oct 2, 8:56 AM.
Tags
None
Referenced Files
F2868218: D13575.id44828.diff
Wed, Oct 2, 2:54 PM
F2867473: D13575.id.diff
Wed, Oct 2, 1:58 PM
F2867456: D13575.id44839.diff
Wed, Oct 2, 1:49 PM
F2867455: D13575.id44828.diff
Wed, Oct 2, 1:49 PM
F2867447: D13575.id.diff
Wed, Oct 2, 1:49 PM
F2867441: D13575.diff
Wed, Oct 2, 1:48 PM
F2867255: D13575.diff
Wed, Oct 2, 1:14 PM
Subscribers
ashoat
tomek

Details

Reviewers
bartek
will
ashoat
Summary

Depends on D13574

Same as previous diff but for web. We want to send OTKs on login since the device ID will be new

https://linear.app/comm/issue/ENG-9440/clients-should-include-otks-on-first-login

Test Plan

logged in and out multiple times on web. confirmed that the device ID changed in device list and that the OTKs were added (and removed on logout) for each device

tested both password and wallet login

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
types/
9 lines
web/
grpc/
47 lines
shared-worker/
worker/
6 lines
34 lines

Diff 44839

View Options

lib/types/identity-service-types.js

Loading...
View Options

web/grpc/identity-service-client-wrapper.js

Loading...
View Options

web/shared-worker/worker/identity-client.js

Loading...
View Options

web/shared-worker/worker/worker-crypto.js

Loading...