Page MenuHomePhabricator
Differential D13574

[native] undo changes that removed one time keys from identity v1 login calls
Needs ReviewPublic
Actions

Authored by varun on Wed, Oct 2, 8:54 AM.

Details

Reviewers
bartek
will
Summary

we determined we actually want to send OTKs here because the device connecting to identity should have a fresh device ID, and therefore 0 pre-existing OTKs in DynamoDB.

https://linear.app/comm/issue/ENG-9440/clients-should-include-otks-on-first-login

Test Plan

log in to existing account from fresh simulator device, confirm that OTKs are present on DynamoDB

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
8 lines
16 lines
_generated/
identity-service/
32 lines
native_rust_library/
src/
identity/
12 lines
4 lines
schema/
4 lines

Diff 44838

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI.h

Loading...
View Options

native/identity-service/identity-service-context-provider.react.js

Loading...
View Options

native/native_rust_library/src/identity/login.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

native/schema/CommRustModuleSchema.js

Loading...