[identity] implement privileged delete users RPC
ClosedPublic
Actions

Authored by varun on Mon, Oct 7, 8:03 PM.

Details

Reviewers

bartek
will

Commits

rCOMMbad0b9aafcb2: [identity] implement privileged delete users RPC

Summary

check if caller is staff. if they are, then delete the users whose IDs are provided in the request

Depends on D13629

Test Plan

tested in next diff by calling RPC

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Mon, Oct 7, 8:03 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Oct 7, 8:03 PM

varun added a child revision: D13631: [rust-node-addon] add rust function and binding type for privilegedDeleteUsers.Mon, Oct 7, 8:08 PM

Harbormaster completed remote builds in B32099: Diff 44960.Mon, Oct 7, 8:20 PM

varun requested review of this revision.Mon, Oct 7, 8:20 PM

bartek accepted this revision.Tue, Oct 8, 12:54 AM

bartek added inline comments.

services/identity/src/grpc_services/authenticated.rs
630 ↗	(On Diff #44960)	In the future we might want to extract it or make readable from some JSON file or sth, but for now let's leave it as is 👍

This revision is now accepted and ready to land.Tue, Oct 8, 12:54 AM

Closed by commit rCOMMbad0b9aafcb2: [identity] implement privileged delete users RPC (authored by varun). · Explain WhyTue, Oct 8, 6:42 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMbad0b9aafcb2: [identity] implement privileged delete users RPC.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

constants.rs

1 line

grpc_services/

authenticated.rs

21 lines

Diff 44964

View Options

services/identity/src/constants.rs