Page MenuHomePhabricator

[lib][native][web] Introduce chatMessageItemHasEngagement
ClosedPublic

Authored by ashoat on Oct 9 2024, 8:26 PM.
Tags
None
Referenced Files
F3342274: D13678.diff
Fri, Nov 22, 1:02 AM
Unknown Object (File)
Sun, Nov 10, 3:18 PM
Unknown Object (File)
Sun, Nov 10, 2:38 PM
Unknown Object (File)
Sun, Nov 10, 10:26 AM
Unknown Object (File)
Sun, Nov 10, 1:01 AM
Unknown Object (File)
Sat, Nov 2, 3:00 AM
Unknown Object (File)
Fri, Nov 1, 6:39 AM
Unknown Object (File)
Fri, Nov 1, 3:38 AM
Subscribers
None

Details

Summary

This diff addresses a bug where MultimediaMessageTooltipButton and TextMessageTooltipButton on native were only rendering TooltipInlineEngagement when a sidebar existed, but not when a reaction existed.

TooltipInlineEngagement is meant to be rendered exactly when InlineEngagement is, so these checks should be identical. It was introduced in D4825, which was (slightly) before reactions were implemented (you can see reactions in the test plan, but diff comments review that it was hacked as a demo, and reactions at the time had not been landed yet).

Depends on D13677

Test Plan

Confirm visually (on iOS simulator) that TooltipInlineEngagement gets rendered over cases where a message has a reaction but not a sidebar

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage