Page MenuHomePhabricator

[lib][native][web] Introduce chatMessageItemHasEngagement
ClosedPublic

Authored by ashoat on Wed, Oct 9, 8:26 PM.
Tags
None
Referenced Files
F3098937: D13678.id45119.diff
Tue, Oct 29, 7:39 PM
Unknown Object (File)
Mon, Oct 28, 11:32 AM
Unknown Object (File)
Sun, Oct 27, 1:16 PM
Unknown Object (File)
Sat, Oct 26, 4:58 PM
Unknown Object (File)
Fri, Oct 25, 6:53 PM
Unknown Object (File)
Thu, Oct 24, 3:21 AM
Unknown Object (File)
Tue, Oct 22, 8:31 PM
Unknown Object (File)
Sat, Oct 19, 9:08 PM
Subscribers
None

Details

Summary

This diff addresses a bug where MultimediaMessageTooltipButton and TextMessageTooltipButton on native were only rendering TooltipInlineEngagement when a sidebar existed, but not when a reaction existed.

TooltipInlineEngagement is meant to be rendered exactly when InlineEngagement is, so these checks should be identical. It was introduced in D4825, which was (slightly) before reactions were implemented (you can see reactions in the test plan, but diff comments review that it was hacked as a demo, and reactions at the time had not been landed yet).

Depends on D13677

Test Plan

Confirm visually (on iOS simulator) that TooltipInlineEngagement gets rendered over cases where a message has a reaction but not a sidebar

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable