Page MenuHomePhabricator
Differential D13685

[lib][native] Extract chatMessageItemEngagementTargetMessageInfo
ClosedPublic
Actions

Authored by ashoat on Wed, Oct 9, 8:30 PM.
Tags
None
Referenced Files
F3099541: D13685.id45126.diff
Tue, Oct 29, 11:13 PM
Unknown Object (File)
Mon, Oct 28, 3:48 PM
Unknown Object (File)
Wed, Oct 23, 9:43 PM
Unknown Object (File)
Wed, Oct 23, 6:59 AM
Unknown Object (File)
Tue, Oct 22, 10:51 AM
Unknown Object (File)
Tue, Oct 22, 10:20 AM
Unknown Object (File)
Sat, Oct 19, 9:12 AM
Unknown Object (File)
Sat, Oct 19, 4:26 AM
View All 24 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMMa5188d988608: [lib][native] Extract chatMessageItemEngagementTargetMessageInfo
Summary

This will make it easier to change its behavior in a later diff.

Depends on D13684

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Wed, Oct 9, 8:30 PM
ashoat added a child revision: D13686: [lib][native][web] Add support for rendering array of messages in RobotextChatMessageInfoItem.
Harbormaster completed remote builds in B32169: Diff 45044.Wed, Oct 9, 9:59 PM
ashoat requested review of this revision.Wed, Oct 9, 9:59 PM
tomek accepted this revision.Fri, Oct 11, 6:12 AM
tomek added inline comments.
lib/shared/chat-message-item-utils.js
43 ↗(On Diff #45044)

I'm not sure what this name means. What makes a message targetable?

This revision is now accepted and ready to land.Fri, Oct 11, 6:12 AM
ashoat added inline comments.Sun, Oct 13, 5:08 PM
lib/shared/chat-message-item-utils.js
43 ↗(On Diff #45044)

I'll rename to chatMessageItemCanReceiveEngagement for consistency with chatMessageItemHasEngagement

ashoat added inline comments.Sun, Oct 13, 5:24 PM
lib/shared/chat-message-item-utils.js
43 ↗(On Diff #45044)

Actually, it returns a MessageInfo so that doesn't make sense. I'll go with chatMessageItemEngagementTargetMessageInfo

ashoat retitled this revision from [lib][native] Extract chatMessageInfoItemTargetableMessageInfo to [lib][native] Extract chatMessageItemEngagementTargetMessageInfo.Sun, Oct 13, 5:29 PM
ashoat updated this revision to Diff 45105.Sun, Oct 13, 5:32 PM

chatMessageInfoItemTargetableMessageInfo -> chatMessageItemEngagementTargetMessageInfo

Harbormaster completed remote builds in B32209: Diff 45105.Sun, Oct 13, 5:51 PM
Closed by commit rCOMMa5188d988608: [lib][native] Extract chatMessageItemEngagementTargetMessageInfo (authored by ashoat). · Explain WhySun, Oct 13, 6:44 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMa5188d988608: [lib][native] Extract chatMessageItemEngagementTargetMessageInfo.

Revision Contents
Changeset List

Diff 45105

View Options

lib/shared/chat-message-item-utils.js

Loading...
View Options

lib/shared/sidebar-utils.js

Loading...
View Options

native/chat/robotext-message-tooltip-button.react.js

Loading...
View Options

native/chat/robotext-message.react.js

Loading...
View Options

web/chat/robotext-message.react.js

Loading...
View Options

web/modals/chat/toggle-pin-modal.react.js

Loading...
View Options

web/tooltips/message-tooltip.react.js

Loading...
View Options

web/tooltips/tooltip-action-utils.js

Loading...