This will make it easier to change its behavior in a later diff.
Depends on D13684
Details
Details
Flow
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/shared/chat-message-item-utils.js | ||
|---|---|---|
| 43 ↗ | (On Diff #45044) | I'm not sure what this name means. What makes a message targetable? |
| lib/shared/chat-message-item-utils.js | ||
|---|---|---|
| 43 ↗ | (On Diff #45044) | I'll rename to chatMessageItemCanReceiveEngagement for consistency with chatMessageItemHasEngagement |
| lib/shared/chat-message-item-utils.js | ||
|---|---|---|
| 43 ↗ | (On Diff #45044) | Actually, it returns a MessageInfo so that doesn't make sense. I'll go with chatMessageItemEngagementTargetMessageInfo |
Comment Actions
chatMessageInfoItemTargetableMessageInfo -> chatMessageItemEngagementTargetMessageInfo