Page MenuHomePhabricator
Differential D13693

[keyserver] fix db setup
ClosedPublic
Actions

Authored by varun on Oct 10 2024, 8:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 18, 6:20 AM
Unknown Object (File)
Mon, Mar 17, 9:01 AM
Unknown Object (File)
Mon, Mar 17, 8:53 AM
Unknown Object (File)
Tue, Mar 11, 6:49 AM
Unknown Object (File)
Tue, Mar 11, 6:29 AM
Unknown Object (File)
Mon, Mar 10, 9:30 AM
Unknown Object (File)
Mon, Mar 3, 3:10 PM
Unknown Object (File)
Mon, Mar 3, 9:02 AM
View All 78 Files
Subscribers
tomek

Details

Reviewers
inka
kamil
ashoat
Commits
rCOMM722342557c7f: [keyserver] fix db setup
Summary

don't use fetchCallUpdateOlmAccount from verifyUserLoggedInWithoutDB

resolves https://linear.app/comm/issue/ENG-9583/running-keyserver-with-fresh-db-is-broken

Test Plan

i'm able to set up a fresh keyserver with no issues

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Oct 10 2024, 8:26 AM
Herald added a subscriber: tomek. · View Herald TranscriptOct 10 2024, 8:26 AM
varun published this revision for review.Oct 10 2024, 8:30 AM
varun edited the test plan for this revision. (Show Details)

will wait for CI before landing

varun edited the summary of this revision. (Show Details)Oct 10 2024, 8:44 AM
Harbormaster completed remote builds in B32179: Diff 45058.Oct 10 2024, 8:44 AM
varun added inline comments.Oct 10 2024, 8:46 AM
keyserver/src/user/login.js
194

we already use the correct function, getUpdateContentAccount, here

ashoat accepted this revision.Oct 10 2024, 9:50 AM
This revision is now accepted and ready to land.Oct 10 2024, 9:50 AM
Closed by commit rCOMM722342557c7f: [keyserver] fix db setup (authored by varun). · Explain WhyOct 10 2024, 9:51 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM722342557c7f: [keyserver] fix db setup.

Revision Contents
Changeset List

PathSize
keyserver/
src/
user/
2 lines

Diff 45058

View Options

keyserver/src/user/login.js

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Lines +findUserIdentities: (
userIds: $ReadOnlyArray<string>, userIds: $ReadOnlyArray<string>,
) => Promise<UserIdentitiesResponse>, ) => Promise<UserIdentitiesResponse>,
+privilegedDeleteUsers: ( +privilegedDeleteUsers: (
authUserId: string, authUserId: string,
authDeviceId: string, authDeviceId: string,
authAccessToken: string, authAccessToken: string,
userIds: $ReadOnlyArray<string>, userIds: $ReadOnlyArray<string>,
) => Promise<void>, ) => Promise<void>,
+syncPlatformDetails: (
userId: string,
deviceId: string,
accessToken: string,
) => Promise<void>,
}; };
export type { RustNativeBindingAPI }; export type { RustNativeBindingAPI };