Paths

Table of Contentst

[identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib`
AcceptedPublic
Actions

Authored by kamil on Tue, Oct 29, 7:47 AM.

Details

Reviewers

varun
bartek

Summary

ENG-6145.

We'll need to use this on backup, to be able to call FindUserID RPC based on public user identifier - we need to somehow know if this is a Password or Wallet user

Test Plan

Run unit tests in Identity and comm-lib

Diff Detail

Repository

rCOMM Comm

Branch

backup-work

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Tue, Oct 29, 7:47 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Oct 29, 7:47 AM

kamil added a child revision: D13805: [commtest] use registered `UserIdentity` in backup tests.Tue, Oct 29, 7:59 AM

Harbormaster failed remote builds in B32399: Diff 45421!Tue, Oct 29, 8:01 AM

CI v2

Harbormaster failed remote builds in B32402: Diff 45424!Tue, Oct 29, 8:38 AM

Harbormaster completed remote builds in B32403: Diff 45425.Tue, Oct 29, 8:50 AM

kamil published this revision for review.Wed, Oct 30, 9:28 AM

varun accepted this revision.Wed, Oct 30, 10:18 AM

This revision is now accepted and ready to land.Wed, Oct 30, 10:18 AM

Revision Contents
Changeset List

Path

Size

Cargo.lock

native/

native_rust_library/

Cargo.lock

services/

backup/

Cargo.toml

1 line

identity/

Cargo.toml

1 line

src/

client_service.rs

7 lines

siwe.rs

46 lines

shared/

comm-lib/

Cargo.toml

1 line

src/

crypto/

mod.rs

1 line

siwe.rs

52 lines

Diff 45421

View Options

Cargo.lock

View Options

native/native_rust_library/Cargo.lock

View Options

services/backup/Cargo.toml

View Options

services/identity/Cargo.toml

View Options

services/identity/src/client_service.rs

View Options

services/identity/src/siwe.rs

View Options

shared/comm-lib/Cargo.toml

View Options

shared/comm-lib/src/crypto/mod.rs

View Options

shared/comm-lib/src/crypto/siwe.rs

[identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib`AcceptedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45421

Cargo.lock

native/native_rust_library/Cargo.lock

services/backup/Cargo.toml

services/identity/Cargo.toml

services/identity/src/client_service.rs

services/identity/src/siwe.rs

shared/comm-lib/Cargo.toml

shared/comm-lib/src/crypto/mod.rs

shared/comm-lib/src/crypto/siwe.rs

[identity][comm-lib] move `is_valid_ethereum_address` to `comm-lib`
AcceptedPublic
Actions

Revision Contents
Changeset List