Page MenuHomePhabricator
Differential D13863

[lib] Remove unecessary utils-copy-error dependency
ClosedPublic
Actions

Authored by angelika on Nov 4 2024, 12:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 18, 6:31 AM
Unknown Object (File)
Mon, Mar 17, 9:23 PM
Unknown Object (File)
Mon, Mar 17, 8:35 PM
Unknown Object (File)
Mon, Mar 17, 8:32 PM
Unknown Object (File)
Mon, Mar 17, 7:40 PM
Unknown Object (File)
Fri, Mar 14, 5:46 AM
Unknown Object (File)
Fri, Mar 14, 5:31 AM
Unknown Object (File)
Fri, Mar 14, 4:49 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
ashoat
Commits
rCOMM90e919811458: [lib] Remove unecessary utils-copy-error dependency
Summary

Part of https://linear.app/comm/issue/ENG-9730/native-crashes-when-call-to-identity-fails

Depends on D13862

Test Plan

Run yarn and make sure nothing crashes

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

angelika created this revision.Nov 4 2024, 12:43 PM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 4 2024, 12:43 PM
angelika added a child revision: D13864: [lib] Don't swallow errors in useGetAndUpdateDeviceListsForUsers.Nov 4 2024, 12:46 PM
Harbormaster completed remote builds in B32521: Diff 45587.Nov 4 2024, 1:01 PM
angelika requested review of this revision.Nov 4 2024, 1:01 PM
ashoat added a comment.Nov 4 2024, 6:20 PM

Love to see a dependency get removed!!

ashoat accepted this revision.Nov 4 2024, 6:21 PM
This revision is now accepted and ready to land.Nov 4 2024, 6:21 PM
angelika updated this revision to Diff 45599.Nov 5 2024, 3:45 AM

Rebase

Harbormaster completed remote builds in B32531: Diff 45599.Nov 5 2024, 4:04 AM
angelika updated this revision to Diff 45645.Nov 6 2024, 5:43 AM

Rebase

Harbormaster completed remote builds in B32562: Diff 45645.Nov 6 2024, 6:05 AM
Closed by commit rCOMM90e919811458: [lib] Remove unecessary utils-copy-error dependency (authored by angelika). · Explain WhyNov 6 2024, 6:41 AM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM90e919811458: [lib] Remove unecessary utils-copy-error dependency.

Revision Contents
Changeset List

PathSize
lib/
1 line
100 lines

Diff 45645

View Options

lib/package.json

// @flow // @flow
import { import {
setDeviceTokenActionTypes, setDeviceTokenActionTypes,
type SetDeviceTokenStartedPayload, type SetDeviceTokenStartedPayload,
} from '../actions/device-actions.js'; } from '../actions/device-actions.js';
import { setTBDeviceTokenActionTypes } from '../actions/tunnelbroker-actions.js'; import {
invalidateTunnelbrokerDeviceToken,
setTBDeviceTokenActionTypes,
} from '../actions/tunnelbroker-actions.js';
import type { BaseAction } from '../types/redux-types.js'; import type { BaseAction } from '../types/redux-types.js';
import type { TunnelbrokerDeviceToken } from '../types/tunnelbroker-device-token-types.js'; import type { TunnelbrokerDeviceToken } from '../types/tunnelbroker-device-token-types.js';
function reduceTunnelbrokerDeviceToken( function reduceTunnelbrokerDeviceToken(
state: TunnelbrokerDeviceToken, state: TunnelbrokerDeviceToken,
action: BaseAction, action: BaseAction,
): TunnelbrokerDeviceToken { ): TunnelbrokerDeviceToken {
if (action.type === setDeviceTokenActionTypes.started) { if (action.type === setDeviceTokenActionTypes.started) {
const payload: SetDeviceTokenStartedPayload = action.payload; const payload: SetDeviceTokenStartedPayload = action.payload;
if (payload.type === 'nothing_to_set') { if (payload.type === 'nothing_to_set') {
return state; return state;
} }
if (payload.type === 'clear_device_token') { if (payload.type === 'clear_device_token') {
return { ...state, localToken: null }; return { ...state, localToken: null };
} }
return { ...state, localToken: payload.deviceToken }; return { ...state, localToken: payload.deviceToken };
} else if (action.type === setTBDeviceTokenActionTypes.success) { } else if (action.type === setTBDeviceTokenActionTypes.success) {
const { deviceToken } = action.payload; const { deviceToken } = action.payload;
return { ...state, tunnelbrokerToken: deviceToken }; return { ...state, tunnelbrokerToken: deviceToken };
} else if (action.type === invalidateTunnelbrokerDeviceToken) {
const { deviceToken } = action.payload;
if (state.localToken !== deviceToken) {
return state;
}
return {
...state,
localToken: null,
tunnelbrokerToken: null,
};
} }
return state; return state;
} }
export default reduceTunnelbrokerDeviceToken; export default reduceTunnelbrokerDeviceToken;
View Options

yarn.lock

// @flow // @flow
import { import {
setDeviceTokenActionTypes, setDeviceTokenActionTypes,
type SetDeviceTokenStartedPayload, type SetDeviceTokenStartedPayload,
} from '../actions/device-actions.js'; } from '../actions/device-actions.js';
import { setTBDeviceTokenActionTypes } from '../actions/tunnelbroker-actions.js'; import {
invalidateTunnelbrokerDeviceToken,
setTBDeviceTokenActionTypes,
} from '../actions/tunnelbroker-actions.js';
import type { BaseAction } from '../types/redux-types.js'; import type { BaseAction } from '../types/redux-types.js';
import type { TunnelbrokerDeviceToken } from '../types/tunnelbroker-device-token-types.js'; import type { TunnelbrokerDeviceToken } from '../types/tunnelbroker-device-token-types.js';
function reduceTunnelbrokerDeviceToken( function reduceTunnelbrokerDeviceToken(
state: TunnelbrokerDeviceToken, state: TunnelbrokerDeviceToken,
action: BaseAction, action: BaseAction,
): TunnelbrokerDeviceToken { ): TunnelbrokerDeviceToken {
if (action.type === setDeviceTokenActionTypes.started) { if (action.type === setDeviceTokenActionTypes.started) {
const payload: SetDeviceTokenStartedPayload = action.payload; const payload: SetDeviceTokenStartedPayload = action.payload;
if (payload.type === 'nothing_to_set') { if (payload.type === 'nothing_to_set') {
return state; return state;
} }
if (payload.type === 'clear_device_token') { if (payload.type === 'clear_device_token') {
return { ...state, localToken: null }; return { ...state, localToken: null };
} }
return { ...state, localToken: payload.deviceToken }; return { ...state, localToken: payload.deviceToken };
} else if (action.type === setTBDeviceTokenActionTypes.success) { } else if (action.type === setTBDeviceTokenActionTypes.success) {
const { deviceToken } = action.payload; const { deviceToken } = action.payload;
return { ...state, tunnelbrokerToken: deviceToken }; return { ...state, tunnelbrokerToken: deviceToken };
} else if (action.type === invalidateTunnelbrokerDeviceToken) {
const { deviceToken } = action.payload;
if (state.localToken !== deviceToken) {
return state;
}
return {
...state,
localToken: null,
tunnelbrokerToken: null,
};
} }
return state; return state;
} }
export default reduceTunnelbrokerDeviceToken; export default reduceTunnelbrokerDeviceToken;