Points 3a and 3b from ENG-6459.
Details
Replaced next code version constant with a past version and verified that robotext no longer appears and blob-hosted media messages are displayed.
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
lib/shared/messages/multimedia-message-spec.js | ||
---|---|---|
256 ↗ | (On Diff #45655) | We've never been shimming these for web. This code was written before we started versioning web |
First, give this comment a read.
Basically my thinking is that if we want to have clients immediately start sending blob-hosted multimedia in thin threads, we should also stop shimming blob-hosted multimedia on the keyserver for recent codeVersions.
Rather than only unshimming for the most recent codeVersions, we should instead unshim for any codeVersion that can support blob-hosted multimedia.
lib/shared/messages/multimedia-message-spec.js | ||
---|---|---|
256 | Please replace NEXT_CODE_VERSION here with the earliest codeVersion that supports blob-hosted multimedia. (Would be helpful to explain your reasoning) |
lib/shared/messages/multimedia-message-spec.js | ||
---|---|---|
256 | I think this would be 313: https://github.com/CommE2E/comm/compare/mobile-v1.0.311...mobile-v1.0.313 |
lib/shared/messages/multimedia-message-spec.js | ||
---|---|---|
256 | Actually it should be 389 because since this release we enabled CSAT for everyone. Previous releases can have it missing: https://github.com/CommE2E/comm/tree/mobile-v1.0.389 |
lib/shared/messages/multimedia-message-spec.js | ||
---|---|---|
256 | Makes sense to me! |
I rebased on latest master which is this commit: d8ed20cf4b9c1488f208825b7a636b3e5d882f6d
Sorry, you're absolutely right... that was my mistake, I mixed up FUTURE_CODE_VERSION and NEXT_CODE_VERSION