Page MenuHomePhabricator
Differential D13944

[terraform] create backup cloudwatch alarms
ClosedPublic
Actions

Authored by will on Nov 14 2024, 8:57 PM.
Tags
None
Referenced Files
F3512594: D13944.id45857.diff
Sat, Dec 21, 8:28 PM
F3512592: D13944.id45835.diff
Sat, Dec 21, 8:28 PM
F3512550: D13944.id.diff
Sat, Dec 21, 8:27 PM
F3512522: D13944.diff
Sat, Dec 21, 8:26 PM
Unknown Object (File)
Mon, Dec 16, 1:13 AM
Unknown Object (File)
Thu, Dec 5, 3:55 PM
Unknown Object (File)
Thu, Dec 5, 11:06 AM
Unknown Object (File)
Fri, Nov 29, 9:10 PM
View All 35 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
varun
Commits
rCOMM9fe6ac4e8124: [terraform] create backup cloudwatch alarms
Summary

This creates the backup cloudwatch alarms that were added to backup in https://phab.comm.dev/D13942

Depends on D13943

Test Plan

Triggered alarms by including tracing error logs with each newly implemented errorType in the main.rs file in backup. Confirmed that alarms were triggered and emails were sent.

Linear issues were also created for error log alarms

image.png (430×630 px, 83 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Nov 14 2024, 8:57 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 14 2024, 8:57 PM
Harbormaster completed remote builds in B32676: Diff 45835.Nov 14 2024, 9:16 PM
will requested review of this revision.Nov 14 2024, 9:16 PM
varun accepted this revision.EditedNov 15 2024, 8:43 AM
varun added 1 blocking reviewer(s): bartek.

can you please make sure that Linear creates issues when these alarms go off?

setting bartek as blocking since he's more familiar with the backup service

will added a comment.Nov 15 2024, 8:51 AM
This comment was removed by will.
will edited the test plan for this revision. (Show Details)Nov 15 2024, 8:52 AM
bartek accepted this revision.Nov 16 2024, 1:31 AM
This revision is now accepted and ready to land.Nov 16 2024, 1:31 AM
Closed by commit rCOMM9fe6ac4e8124: [terraform] create backup cloudwatch alarms (authored by will). · Explain WhyNov 18 2024, 4:54 AM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM9fe6ac4e8124: [terraform] create backup cloudwatch alarms.

Revision Contents
Changeset List

PathSize
services/
terraform/
remote/
82 lines

Diff 45857

View Options

services/terraform/remote/alarms_backup.tf

Loading...