Page MenuHomePhabricator
Differential D13983

[lib] Don't query Neynar for Farcaster channel avatars if unused
ClosedPublic
Actions

Authored by ashoat on Nov 20 2024, 6:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 4:29 PM
Unknown Object (File)
Tue, Apr 1, 1:46 PM
Unknown Object (File)
Tue, Apr 1, 12:51 PM
Unknown Object (File)
Tue, Apr 1, 4:10 AM
Unknown Object (File)
Tue, Apr 1, 2:43 AM
Unknown Object (File)
Mon, Mar 31, 12:20 AM
Unknown Object (File)
Tue, Mar 11, 4:17 PM
Unknown Object (File)
Tue, Mar 11, 3:53 PM
View All 85 Files
Subscribers
tomek

Details

Reviewers
varun
will
Commits
rCOMM4d11d51c931e: [lib] Don't query Neynar for Farcaster channel avatars if unused
Summary

This eliminates most fetches, since we mostly aren't using Farcaster channel avatars yet.

Depends on D13982

Test Plan
  1. In combination with other diffs, tested that channel avatars still load on both web and native
  2. Tested on both native and web by logging each NeynarClient query and seeing which ones get triggered

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
components/
17 lines
shared/
6 lines

Diff 45907

View Options

lib/components/farcaster-channel-prefetch-handler.react.js

Show All 35 Lines <div className={css.wrapper}>
<TeamProfile <TeamProfile
name="Ashoat Tevosyan" name="Ashoat Tevosyan"
role="Founder" role="Founder"
githubHandle="ashoat" githubHandle="ashoat"
twitterHandle="ashoat" twitterHandle="ashoat"
imageURL={`${assetsCacheURLPrefix}/ashoat.png`} imageURL={`${assetsCacheURLPrefix}/ashoat.png`}
/> />
<TeamProfile <TeamProfile
name="atul"
role="Software Engineer"
githubHandle="atulsmadhugiri"
twitterHandle="atuli0"
imageURL={`${assetsCacheURLPrefix}/atul.jpeg`}
/>
<TeamProfile
name="Varun Dhananjaya" name="Varun Dhananjaya"
role="Software Engineer" role="Software Engineer"
githubHandle="vdhanan" githubHandle="vdhanan"
twitterHandle="_va_run" twitterHandle="_va_run"
imageURL={`${assetsCacheURLPrefix}/varun.jpeg`} imageURL={`${assetsCacheURLPrefix}/varun.jpeg`}
/> />
<TeamProfile <TeamProfile
name="Mark Rafferty" name="William Wang"
role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
/>
<TeamProfile
name="Anunay Kulshrestha"
role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/anunay.jpg`}
/>
<TeamProfile
name="Ginsu Eddy"
role="Software Engineer" role="Software Engineer"
githubHandle="ginsueddy" imageURL={`${assetsCacheURLPrefix}/will.jpg`}
twitterHandle="ginsueddy" githubHandle="wyilio"
imageURL={`${assetsCacheURLPrefix}/ginsu.jpg`}
/> />
<TeamProfile <TeamProfile
name="Rohan Khanderia" name="Yiannis Tselekounis"
role="Software Engineer" role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/rohan.jpg`} imageURL={`${assetsCacheURLPrefix}/yiannis.jpeg`}
githubHandle="RohanK6"
/> />
<TeamProfile <TeamProfile
name="William Wang" name="Mark Rafferty"
role="Software Engineer" role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/will.jpg`} imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
githubHandle="wyilio"
/> />
</div> </div>
</section> </section>
<h2 className={headerClassName}>Team at Software Mansion</h2> <h2 className={headerClassName}>Team at Software Mansion</h2>
<section className={css.teamWrapper}> <section className={css.teamWrapper}>
<TeamProfile <TeamProfile
name="Tomasz Pałys" name="Tomasz Pałys"
role="Software Engineer" role="Software Engineer"
githubHandle="palys-swm" githubHandle="palys-swm"
imageURL={`${assetsCacheURLPrefix}/tomek.png`} imageURL={`${assetsCacheURLPrefix}/tomek.png`}
/> />
<TeamProfile <TeamProfile
name="Marcin Wasowicz"
role="Software Engineer"
githubHandle="marcinwasowicz"
imageURL={`${assetsCacheURLPrefix}/marcin.jpeg`}
/>
<TeamProfile
name="Inka Sokolowska"
role="Software Engineer"
githubHandle="InkaAlicja"
imageURL={`${assetsCacheURLPrefix}/inka.jpg`}
/>
<TeamProfile
name="Kamil Kurowski" name="Kamil Kurowski"
role="Software Engineer" role="Software Engineer"
githubHandle="xsanm" githubHandle="xsanm"
imageURL={`${assetsCacheURLPrefix}/kamil.jpg`} imageURL={`${assetsCacheURLPrefix}/kamil.jpg`}
/> />
<TeamProfile <TeamProfile
name="Michał Gniadek"
role="Software Engineer"
githubHandle="MichalGniadek"
imageURL={`${assetsCacheURLPrefix}/michał.jpg`}
/>
<TeamProfile
name="Bartłomiej Klocek" name="Bartłomiej Klocek"
role="Software Engineer" role="Software Engineer"
githubHandle="barthap" githubHandle="barthap"
twitterHandle="barthap10" twitterHandle="barthap10"
imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`} imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`}
/> />
<TeamProfile <TeamProfile
name="Aleksandra Grzęda" name="Angelika Serwa"
role="Project Manager" role="Software Engineer"
imageURL={`${assetsCacheURLPrefix}/aleksandra.jpg`} githubHandle="graszka22"
imageURL={`${assetsCacheURLPrefix}/angelika.png`}
/> />
<TeamProfile <TeamProfile
name="Monika Kulczyńska" name="Monika Kulczyńska"
role="Project Manager" role="Project Manager"
imageURL={`${assetsCacheURLPrefix}/monika.jpg`} imageURL={`${assetsCacheURLPrefix}/monika.jpg`}
/> />
</section> </section>
</div> </div>
); );
} }
export default Team; export default Team;
View Options

lib/shared/avatar-utils.js

Show All 35 Lines <div className={css.wrapper}>
<TeamProfile <TeamProfile
name="Ashoat Tevosyan" name="Ashoat Tevosyan"
role="Founder" role="Founder"
githubHandle="ashoat" githubHandle="ashoat"
twitterHandle="ashoat" twitterHandle="ashoat"
imageURL={`${assetsCacheURLPrefix}/ashoat.png`} imageURL={`${assetsCacheURLPrefix}/ashoat.png`}
/> />
<TeamProfile <TeamProfile
name="atul"
role="Software Engineer"
githubHandle="atulsmadhugiri"
twitterHandle="atuli0"
imageURL={`${assetsCacheURLPrefix}/atul.jpeg`}
/>
<TeamProfile
name="Varun Dhananjaya" name="Varun Dhananjaya"
role="Software Engineer" role="Software Engineer"
githubHandle="vdhanan" githubHandle="vdhanan"
twitterHandle="_va_run" twitterHandle="_va_run"
imageURL={`${assetsCacheURLPrefix}/varun.jpeg`} imageURL={`${assetsCacheURLPrefix}/varun.jpeg`}
/> />
<TeamProfile <TeamProfile
name="Mark Rafferty" name="William Wang"
role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
/>
<TeamProfile
name="Anunay Kulshrestha"
role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/anunay.jpg`}
/>
<TeamProfile
name="Ginsu Eddy"
role="Software Engineer" role="Software Engineer"
githubHandle="ginsueddy" imageURL={`${assetsCacheURLPrefix}/will.jpg`}
twitterHandle="ginsueddy" githubHandle="wyilio"
imageURL={`${assetsCacheURLPrefix}/ginsu.jpg`}
/> />
<TeamProfile <TeamProfile
name="Rohan Khanderia" name="Yiannis Tselekounis"
role="Software Engineer" role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/rohan.jpg`} imageURL={`${assetsCacheURLPrefix}/yiannis.jpeg`}
githubHandle="RohanK6"
/> />
<TeamProfile <TeamProfile
name="William Wang" name="Mark Rafferty"
role="Software Engineer" role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/will.jpg`} imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
githubHandle="wyilio"
/> />
</div> </div>
</section> </section>
<h2 className={headerClassName}>Team at Software Mansion</h2> <h2 className={headerClassName}>Team at Software Mansion</h2>
<section className={css.teamWrapper}> <section className={css.teamWrapper}>
<TeamProfile <TeamProfile
name="Tomasz Pałys" name="Tomasz Pałys"
role="Software Engineer" role="Software Engineer"
githubHandle="palys-swm" githubHandle="palys-swm"
imageURL={`${assetsCacheURLPrefix}/tomek.png`} imageURL={`${assetsCacheURLPrefix}/tomek.png`}
/> />
<TeamProfile <TeamProfile
name="Marcin Wasowicz"
role="Software Engineer"
githubHandle="marcinwasowicz"
imageURL={`${assetsCacheURLPrefix}/marcin.jpeg`}
/>
<TeamProfile
name="Inka Sokolowska"
role="Software Engineer"
githubHandle="InkaAlicja"
imageURL={`${assetsCacheURLPrefix}/inka.jpg`}
/>
<TeamProfile
name="Kamil Kurowski" name="Kamil Kurowski"
role="Software Engineer" role="Software Engineer"
githubHandle="xsanm" githubHandle="xsanm"
imageURL={`${assetsCacheURLPrefix}/kamil.jpg`} imageURL={`${assetsCacheURLPrefix}/kamil.jpg`}
/> />
<TeamProfile <TeamProfile
name="Michał Gniadek"
role="Software Engineer"
githubHandle="MichalGniadek"
imageURL={`${assetsCacheURLPrefix}/michał.jpg`}
/>
<TeamProfile
name="Bartłomiej Klocek" name="Bartłomiej Klocek"
role="Software Engineer" role="Software Engineer"
githubHandle="barthap" githubHandle="barthap"
twitterHandle="barthap10" twitterHandle="barthap10"
imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`} imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`}
/> />
<TeamProfile <TeamProfile
name="Aleksandra Grzęda" name="Angelika Serwa"
role="Project Manager" role="Software Engineer"
imageURL={`${assetsCacheURLPrefix}/aleksandra.jpg`} githubHandle="graszka22"
imageURL={`${assetsCacheURLPrefix}/angelika.png`}
/> />
<TeamProfile <TeamProfile
name="Monika Kulczyńska" name="Monika Kulczyńska"
role="Project Manager" role="Project Manager"
imageURL={`${assetsCacheURLPrefix}/monika.jpg`} imageURL={`${assetsCacheURLPrefix}/monika.jpg`}
/> />
</section> </section>
</div> </div>
); );
} }
export default Team; export default Team;