Page MenuHomePhabricator
Differential D14109

[native] Move styles in Tooltip to functional component
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 7:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 7:44 PM
Unknown Object (File)
Tue, Dec 17, 6:01 PM
Unknown Object (File)
Fri, Dec 13, 11:17 PM
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM1c737fc5e84e: [native] Move styles in Tooltip to functional component
Summary

Simply move styles to functional component as a part of Tooltip migration to functional component.

Depends on D14108

Test Plan

Open up some tooltips and verify they're animated correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Wed, Dec 11, 7:44 AM
angelika held this revision as a draft.
angelika edited the summary of this revision. (Show Details)Wed, Dec 11, 7:45 AM
angelika added a parent revision: D14108: [native] Move Reanimated nodes in Tooltip to functional component.
angelika added a child revision: D14110: [native] Move haptics in Tooltip to functional compononent.Wed, Dec 11, 7:47 AM
Harbormaster completed remote builds in B33009: Diff 46327.Wed, Dec 11, 8:59 AM
angelika published this revision for review.Wed, Dec 11, 4:54 PM
ashoat accepted this revision.Wed, Dec 11, 5:53 PM
ashoat added inline comments.
native/tooltip/tooltip.react.js
152–158 ↗(On Diff #46327)

Some of these changes ideally would've appeared in the earlier diffs where they are relevant, but it doesn't matter enough to update now (feel free to ignore the feedback this time)

This revision is now accepted and ready to land.Wed, Dec 11, 5:53 PM
angelika updated this revision to Diff 46406.Fri, Dec 13, 5:32 AM

Rebase and address feedback

angelika marked an inline comment as done.Fri, Dec 13, 6:13 AM
Harbormaster completed remote builds in B33084: Diff 46406.Fri, Dec 13, 6:41 AM
angelika updated this revision to Diff 46469.Mon, Dec 16, 6:20 AM

Rebase

Harbormaster completed remote builds in B33128: Diff 46469.Mon, Dec 16, 7:36 AM
Closed by commit rCOMM1c737fc5e84e: [native] Move styles in Tooltip to functional component (authored by angelika). · Explain WhyMon, Dec 16, 1:34 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM1c737fc5e84e: [native] Move styles in Tooltip to functional component.

Revision Contents
Changeset List

PathSize
native/
tooltip/
246 lines

Diff 46505

View Options

native/tooltip/tooltip.react.js

Loading...