Page MenuHomePhabricator
Differential D14106

[native] Move tooltip height getter in Tooltip to functional component
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 7:37 AM.
Tags
None
Referenced Files
F3490138: D14106.id46324.diff
Wed, Dec 18, 3:11 PM
Unknown Object (File)
Tue, Dec 17, 3:01 PM
Unknown Object (File)
Tue, Dec 17, 12:22 PM
Unknown Object (File)
Mon, Dec 16, 1:36 PM
Unknown Object (File)
Mon, Dec 16, 1:24 PM
Unknown Object (File)
Fri, Dec 13, 11:17 PM
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMf2b9cc0f5ed6: [native] Move tooltip height getter in Tooltip to functional component
Summary

Simply move get tooltipHeight function to functional component as a part of Tooltip migration to functional component.

Depends on D14104

Test Plan

Open some tooltips and verify they're positioned correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Wed, Dec 11, 7:37 AM
angelika held this revision as a draft.
angelika added a child revision: D14107: [native] Move tooltip location getter in Tooltip to functional component.Wed, Dec 11, 7:40 AM
Harbormaster completed remote builds in B33006: Diff 46324.Wed, Dec 11, 8:30 AM
angelika published this revision for review.Wed, Dec 11, 4:54 PM
ashoat accepted this revision.Wed, Dec 11, 5:44 PM

Similar feedback to last diff: I think these getters can be replaced with the value itself

This revision is now accepted and ready to land.Wed, Dec 11, 5:44 PM
ashoat added inline comments.Wed, Dec 11, 5:47 PM
native/tooltip/tooltip.react.js
565–571 ↗(On Diff #46324)

Nit: it's already been extracted earlier in the file

angelika updated this revision to Diff 46403.Fri, Dec 13, 5:30 AM

Rebase and address feedback

angelika marked an inline comment as done.Fri, Dec 13, 6:10 AM
Harbormaster completed remote builds in B33081: Diff 46403.Fri, Dec 13, 6:16 AM
angelika updated this revision to Diff 46466.Mon, Dec 16, 6:19 AM

Rebase

Harbormaster completed remote builds in B33125: Diff 46466.Mon, Dec 16, 7:10 AM
Closed by commit rCOMMf2b9cc0f5ed6: [native] Move tooltip height getter in Tooltip to functional component (authored by angelika). · Explain WhyMon, Dec 16, 1:34 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMMf2b9cc0f5ed6: [native] Move tooltip height getter in Tooltip to functional component.

Revision Contents
Changeset List

PathSize
native/
tooltip/
28 lines

Diff 46502

View Options

native/tooltip/tooltip.react.js

Loading...