[native] Move tooltip height getter in Tooltip to functional component
ClosedPublic
Actions

Authored by angelika on Dec 11 2024, 3:37 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMf2b9cc0f5ed6: [native] Move tooltip height getter in Tooltip to functional component

Summary

Simply move get tooltipHeight function to functional component as a part of Tooltip migration to functional component.

Depends on D14104

Test Plan

Open some tooltips and verify they're positioned correctly.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Dec 11 2024, 3:37 PM

angelika held this revision as a draft.

angelika added a child revision: D14107: [native] Move tooltip location getter in Tooltip to functional component.Dec 11 2024, 3:40 PM

Harbormaster completed remote builds in B33006: Diff 46324.Dec 11 2024, 4:30 PM

angelika published this revision for review.Dec 12 2024, 12:54 AM

Similar feedback to last diff: I think these getters can be replaced with the value itself

This revision is now accepted and ready to land.Dec 12 2024, 1:44 AM

ashoat added inline comments.Dec 12 2024, 1:47 AM

native/tooltip/tooltip.react.js
565–571	Nit: it's already been extracted earlier in the file

Rebase and address feedback

angelika marked an inline comment as done.Dec 13 2024, 2:10 PM

Harbormaster completed remote builds in B33081: Diff 46403.Dec 13 2024, 2:16 PM

Rebase

Harbormaster completed remote builds in B33125: Diff 46466.Dec 16 2024, 3:10 PM

Closed by commit rCOMMf2b9cc0f5ed6: [native] Move tooltip height getter in Tooltip to functional component. · Explain WhyDec 16 2024, 9:34 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMf2b9cc0f5ed6: [native] Move tooltip height getter in Tooltip to functional component.

Revision Contents
Changeset List

Path

Size

native/

tooltip/

tooltip.react.js

32 lines

Diff 46324

View Options

native/tooltip/tooltip.react.js

[native] Move tooltip height getter in Tooltip to functional componentClosedPublicActions