Details

Reviewers

ashoat
tomek

Commits

rCOMMa9bb37262de6: [native] Migrate ActionResultModal component to Reanimated v2 API

Summary

A straightforward migration: use progressV2 shared value and use useAnimatedStyle

Depends on D14129

Test Plan

Flow and I'd like to navigate to this modal in the app but as far as I searched there is no way to navigate to it so I'm wondering if this modal is still in use. If it's no longer used we can just remove it?

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Dec 11 2024, 8:05 PM

angelika held this revision as a draft.

angelika added a child revision: D14131: [native] Move view ref in MultimediaMessageMultimedia to functional component.Dec 11 2024, 8:08 PM

Harbormaster completed remote builds in B33031: Diff 46349.Dec 11 2024, 8:39 PM

angelika published this revision for review.Dec 12 2024, 1:29 AM

ashoat accepted this revision.Dec 12 2024, 4:02 AM

ashoat added inline comments.

native/navigation/action-result-modal.react.js
38–43 ↗	(On Diff #46349)	Nit
45 ↗	(On Diff #46349)	We usually wrap things like this where the array is re-created on each render with a `React.useMemo`