Page MenuHomePhabricator
Differential D14130

[native] Migrate ActionResultModal component to Reanimated v2 API
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 12:05 PM.
Tags
None
Referenced Files
F3490397: D14130.diff
Wed, Dec 18, 4:09 PM
Unknown Object (File)
Tue, Dec 17, 12:48 PM
Unknown Object (File)
Fri, Dec 13, 9:54 PM
Unknown Object (File)
Fri, Dec 13, 9:54 PM
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMa9bb37262de6: [native] Migrate ActionResultModal component to Reanimated v2 API
Summary

A straightforward migration: use progressV2 shared value and use useAnimatedStyle

Depends on D14129

Test Plan

Flow and I'd like to navigate to this modal in the app but as far as I searched there is no way to navigate to it so I'm wondering if this modal is still in use. If it's no longer used we can just remove it?

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Wed, Dec 11, 12:05 PM
angelika held this revision as a draft.
angelika added a child revision: D14131: [native] Move view ref in MultimediaMessageMultimedia to functional component.Wed, Dec 11, 12:08 PM
Harbormaster completed remote builds in B33031: Diff 46349.Wed, Dec 11, 12:39 PM
angelika published this revision for review.Wed, Dec 11, 5:29 PM
ashoat accepted this revision.Wed, Dec 11, 8:02 PM
ashoat added inline comments.
native/navigation/action-result-modal.react.js
38–43 ↗(On Diff #46349)

Nit

45 ↗(On Diff #46349)

We usually wrap things like this where the array is re-created on each render with a React.useMemo

This revision is now accepted and ready to land.Wed, Dec 11, 8:02 PM
angelika updated this revision to Diff 46424.Fri, Dec 13, 5:41 AM

Rebase and address feedback

angelika marked an inline comment as done.Fri, Dec 13, 6:25 AM
angelika updated this revision to Diff 46447.Fri, Dec 13, 6:37 AM

Fix nit

angelika marked an inline comment as done.Fri, Dec 13, 6:39 AM
Harbormaster completed remote builds in B33102: Diff 46424.Fri, Dec 13, 9:13 AM
Harbormaster completed remote builds in B33109: Diff 46447.Fri, Dec 13, 10:10 AM
angelika updated this revision to Diff 46487.Mon, Dec 16, 6:24 AM

Rebase

Harbormaster completed remote builds in B33146: Diff 46487.Mon, Dec 16, 10:10 AM
Closed by commit rCOMMa9bb37262de6: [native] Migrate ActionResultModal component to Reanimated v2 API (authored by angelika). · Explain WhyMon, Dec 16, 1:34 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMMa9bb37262de6: [native] Migrate ActionResultModal component to Reanimated v2 API.

Revision Contents
Changeset List

PathSize
native/
navigation/
20 lines

Diff 46523

View Options

native/navigation/action-result-modal.react.js

Loading...