Page MenuHomePhabricator
Differential D14124

[native] Migrate ReactionSelectionPopover component to Reanimated V2 API
ClosedPublic
Actions

Authored by angelika on Wed, Dec 11, 10:41 AM.
Tags
None
Referenced Files
F3489785: D14124.diff
Wed, Dec 18, 1:37 PM
F3488478: D14124.diff
Wed, Dec 18, 10:05 AM
Unknown Object (File)
Fri, Dec 13, 11:17 PM
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM1a2d03825cb2: [native] Migrate ReactionSelectionPopover component to Reanimated V2 API
Summary

A straightforward migration: use progressV2 shared value and use useAnimatedStyle instead of useMemo.

Depends on D14123

Test Plan

Open up text message tooltip and verify the reactions popover is animated correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

angelika created this revision.Wed, Dec 11, 10:41 AM
angelika held this revision as a draft.
angelika updated this revision to Diff 46343.Wed, Dec 11, 10:44 AM

Put animationStyle in useMamo

angelika added a child revision: D14125: [native] Migrate MultimediaMessageTooltipButton component to Reanimated V2 API.Wed, Dec 11, 10:47 AM
Harbormaster completed remote builds in B33024: Diff 46342.Wed, Dec 11, 11:29 AM
Harbormaster completed remote builds in B33025: Diff 46343.Wed, Dec 11, 11:41 AM
angelika published this revision for review.Wed, Dec 11, 5:28 PM
ashoat accepted this revision.Wed, Dec 11, 7:55 PM
This revision is now accepted and ready to land.Wed, Dec 11, 7:55 PM
angelika updated this revision to Diff 46418.Fri, Dec 13, 5:37 AM

Rebase and address feedback

Harbormaster completed remote builds in B33096: Diff 46418.Fri, Dec 13, 8:21 AM
angelika updated this revision to Diff 46481.Mon, Dec 16, 6:23 AM

Rebase

Harbormaster completed remote builds in B33140: Diff 46481.Mon, Dec 16, 9:15 AM
Closed by commit rCOMM1a2d03825cb2: [native] Migrate ReactionSelectionPopover component to Reanimated V2 API (authored by angelika). · Explain WhyMon, Dec 16, 1:34 PM
This revision was automatically updated to reflect the committed changes.
angelika added a commit: rCOMM1a2d03825cb2: [native] Migrate ReactionSelectionPopover component to Reanimated V2 API.

Revision Contents
Changeset List

PathSize
native/
chat/
83 lines

Diff 46517

View Options

native/chat/reaction-selection-popover.react.js

Loading...