[native][lib] extract retrieving current user device list to a hook
ClosedPublic
Actions

Authored by kamil on Jan 16 2025, 11:55 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMMfd73616d3a1e: [native][lib] extract retrieving current user device list to a hook

Summary

ENG-10094.

Here, I just move the code around to make it more readable. Changes in this diff are helpful later in the stack

Depends on D14210

Test Plan

Tested later in the stack

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jan 16 2025, 11:55 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 16 2025, 11:55 AM

kamil added a child revision: D14212: [native] extract migrating to new flow to a hook.Jan 16 2025, 12:07 PM

Harbormaster completed remote builds in B33250: Diff 46694.Jan 16 2025, 12:13 PM

kamil published this revision for review.Jan 16 2025, 2:44 PM

kamil edited the summary of this revision. (Show Details)

tomek accepted this revision.Jan 16 2025, 3:10 PM

This revision is now accepted and ready to land.Jan 16 2025, 3:10 PM

I recall there are other places where this hook might also be useful, but I couldn't quickly identify them.

Closed by commit rCOMMfd73616d3a1e: [native][lib] extract retrieving current user device list to a hook. · Explain WhyJan 20 2025, 12:05 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMfd73616d3a1e: [native][lib] extract retrieving current user device list to a hook.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

peer-list-hooks.js

33 lines

native/

backup/

backup-handler.js

30 lines

Diff 46712

View Options

lib/hooks/peer-list-hooks.js