[native] fix creating new device list in `reorderAndSignDeviceList`
ClosedPublic
Actions

Authored by kamil on Jan 16 2025, 2:41 PM.

Details

Reviewers

bartek
tomek

Commits

rCOMM0333f39b9e6a: [native] fix creating new device list in `reorderAndSignDeviceList`

Summary

Fix for ENG-10102.

Depends on D14216

Test Plan

Tested that when running device list o non-primary new device list is properly created

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jan 16 2025, 2:41 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 16 2025, 2:41 PM

kamil published this revision for review.Jan 16 2025, 2:49 PM

kamil edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B33258: Diff 46702.Jan 16 2025, 3:11 PM

tomek accepted this revision.Jan 17 2025, 11:40 AM

This revision is now accepted and ready to land.Jan 17 2025, 11:40 AM

bartek accepted this revision.Jan 17 2025, 12:16 PM

rebase before landing

Harbormaster completed remote builds in B33264: Diff 46710.Jan 20 2025, 12:01 PM

Closed by commit rCOMM0333f39b9e6a: [native] fix creating new device list in `reorderAndSignDeviceList`. · Explain WhyJan 20 2025, 12:05 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM0333f39b9e6a: [native] fix creating new device list in `reorderAndSignDeviceList`.

kamil added a child revision: D14242: [native][lib] implement `useDeviceKind` hook.Jan 21 2025, 1:17 PM

Revision Contents
Changeset List

Path

Size

native/

backup/

use-migration-to-new-flow.js

5 lines

Diff 46717

View Options

native/backup/use-migration-to-new-flow.js

[native] fix creating new device list in `reorderAndSignDeviceList`ClosedPublicActions