[native] extract code in `BackupHandler` to callbacks
ClosedPublic
Actions

Authored by kamil on Jan 21 2025, 1:35 PM.

Details

Reviewers

bartek
tomek

Commits

rCOMM29c849e16f66: [native] extract code in `BackupHandler` to callbacks

Summary

Part of ENG-10094 and ENG-10103.

Moving code around to simplify complex effects, adds some code duplication, but here it is worth it as on the other hand, code is hard to read and maintain.

Conditions are simplified in the next diff in the stack.

Depends on D14243

Test Plan

Tested later in the stack

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jan 21 2025, 1:35 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 21 2025, 1:35 PM

kamil edited the summary of this revision. (Show Details)Jan 21 2025, 1:44 PM

kamil added a child revision: D14245: [native] allow migrating to new flow on secondary device.Jan 21 2025, 1:45 PM

Harbormaster completed remote builds in B33289: Diff 46743.Jan 21 2025, 1:54 PM

kamil published this revision for review.Jan 21 2025, 2:18 PM

bartek accepted this revision.Jan 21 2025, 3:21 PM

This revision is now accepted and ready to land.Jan 21 2025, 3:21 PM

tomek accepted this revision.Jan 21 2025, 5:04 PM

Closed by commit rCOMM29c849e16f66: [native] extract code in `BackupHandler` to callbacks. · Explain WhyJan 22 2025, 9:14 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM29c849e16f66: [native] extract code in `BackupHandler` to callbacks.

Revision Contents
Changeset List

Path

Size

native/

backup/

backup-handler.js

116 lines

Diff 46774

View Options

native/backup/backup-handler.js

[native] extract code in `BackupHandler` to callbacksClosedPublicActions