[native] Migrate take and send photos logic in CameraModal to funcitonal component
ClosedPublic
Actions

Authored by angelika on Jan 20 2025, 12:25 PM.

Details

Reviewers

tomek

Commits

rCOMMdf405a4555c6: [native] Migrate take and send photos logic in CameraModal to funcitonal…

Summary

https://linear.app/comm/issue/ENG-8152/convert-cameramodal-to-reanimated-2-syntax

Just moving functions to functional compoenent. cleanUpPendingPhotoCapture can be outside of a component, since it doesn't depend on anything inside the component..

Depends on D14229

Test Plan

Take and send photos

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Jan 20 2025, 12:25 PM

angelika held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 20 2025, 12:25 PM

angelika added a child revision: D14231: [native] Migrate gestures to RNGH V2 API in CameraModal.Jan 20 2025, 12:30 PM

angelika published this revision for review.Jan 20 2025, 1:26 PM

Harbormaster completed remote builds in B33274: Diff 46727.Jan 20 2025, 1:36 PM

tomek accepted this revision.Jan 20 2025, 3:06 PM

This revision is now accepted and ready to land.Jan 20 2025, 3:06 PM

Rebase

Harbormaster completed remote builds in B33303: Diff 46760.Jan 22 2025, 2:01 AM

Closed by commit rCOMMdf405a4555c6: [native] Migrate take and send photos logic in CameraModal to funcitonal…. · Explain WhyJan 22 2025, 5:39 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMMdf405a4555c6: [native] Migrate take and send photos logic in CameraModal to funcitonal….

Revision Contents
Changeset List

Path

Size

native/

media/

camera-modal.react.js

209 lines

Diff 46793

View Options

native/media/camera-modal.react.js

[native] Migrate take and send photos logic in CameraModal to funcitonal componentClosedPublicActions