[native] Migrate camera buttons in CameraModal to functional component
ClosedPublic
Actions

Authored by angelika on Jan 20 2025, 12:32 PM.

Details

Reviewers

tomek

Commits

rCOMM95e79d11b316: [native] Migrate camera buttons in CameraModal to functional component

Summary

https://linear.app/comm/issue/ENG-8152/convert-cameramodal-to-reanimated-2-syntax

Migrate camera buttons refs and measuring logic to functional component. Migrate related animated
values to useSharedValue in functional component. Migrate outsideButtons function to v2 reanimated
API.

Depends on D14231

Test Plan

Verify focus and zoom works in the next diffs.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Jan 20 2025, 12:32 PM

angelika held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 20 2025, 12:32 PM

angelika added a child revision: D14233: [native] Add withDelay to reanimated flow types.Jan 20 2025, 12:34 PM

angelika published this revision for review.Jan 20 2025, 1:26 PM

Harbormaster completed remote builds in B33276: Diff 46729.Jan 20 2025, 1:53 PM

tomek accepted this revision.Jan 20 2025, 3:20 PM

This revision is now accepted and ready to land.Jan 20 2025, 3:20 PM

Rebase

Harbormaster completed remote builds in B33305: Diff 46762.Jan 22 2025, 2:18 AM

Closed by commit rCOMM95e79d11b316: [native] Migrate camera buttons in CameraModal to functional component. · Explain WhyJan 22 2025, 5:39 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM95e79d11b316: [native] Migrate camera buttons in CameraModal to functional component.

Revision Contents
Changeset List

Path

Size

native/

media/

camera-modal.react.js

332 lines

Diff 46795

View Options

native/media/camera-modal.react.js

[native] Migrate camera buttons in CameraModal to functional componentClosedPublicActions