Differential D14236

[native] Migrate staging mode animation in CameraModal to Reanimated V2 API
ClosedPublic
Actions

Authored by angelika on Jan 20 2025, 1:03 PM.

Details

Reviewers

tomek

Commits

rCOMM1e5169169766: [native] Migrate staging mode animation in CameraModal to Reanimated V2 API

Summary

https://linear.app/comm/issue/ENG-8152/convert-cameramodal-to-reanimated-2-syntax

This is a simple timing animation, so the migration is straightforward.

Depends on D14235

Test Plan

Verify that loading animation when opening modal and taking the photo looks correctly.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Jan 20 2025, 1:03 PM

angelika held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 20 2025, 1:03 PM

angelika added a child revision: D14237: [native] Migrate send button style in CameraModal to functional component.Jan 20 2025, 1:09 PM

angelika published this revision for review.Jan 20 2025, 1:27 PM

Harbormaster completed remote builds in B33280: Diff 46733.Jan 20 2025, 2:27 PM

tomek accepted this revision.Jan 21 2025, 10:01 AM

This revision is now accepted and ready to land.Jan 21 2025, 10:01 AM

Rebase

Harbormaster completed remote builds in B33309: Diff 46766.Jan 22 2025, 2:52 AM

Closed by commit rCOMM1e5169169766: [native] Migrate staging mode animation in CameraModal to Reanimated V2 API. · Explain WhyJan 22 2025, 5:39 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM1e5169169766: [native] Migrate staging mode animation in CameraModal to Reanimated V2 API.

Revision Contents
Changeset List

Path

Size

native/

media/

camera-modal.react.js

60 lines

Diff 46799

View Options

native/media/camera-modal.react.js

[native] Migrate staging mode animation in CameraModal to Reanimated V2 APIClosedPublicActions