Paths

Table of Contentst

Differential D14239

[native] Migrate containerStyle in CameraModal to functional component
ClosedPublic
Actions

Authored by angelika on Jan 20 2025, 1:13 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM84496cc2efe6: [native] Migrate containerStyle in CameraModal to functional component

Summary

https://linear.app/comm/issue/ENG-8152/convert-cameramodal-to-reanimated-2-syntax

A simple migration to useAnimatedStyle

Depends on D14238

Test Plan

Verify opening and closing camera modal works.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Jan 20 2025, 1:13 PM

angelika held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 20 2025, 1:13 PM

angelika added a child revision: D14240: [native] Migrate render functions in CameraModal to functional component.Jan 20 2025, 1:16 PM

angelika published this revision for review.Jan 20 2025, 1:27 PM

Harbormaster completed remote builds in B33283: Diff 46736.Jan 20 2025, 2:53 PM

tomek accepted this revision.Jan 21 2025, 10:13 AM

tomek added inline comments.

native/media/camera-modal.react.js
1053 ↗	(On Diff #46736)	A simple migration to useAnimatedStyle This isn't that simple because we're using `positionV2` which wasn't used in the original code

This revision is now accepted and ready to land.Jan 21 2025, 10:13 AM

Rebase

angelika added inline comments.Jan 22 2025, 12:59 AM

native/media/camera-modal.react.js
1053 ↗	(On Diff #46736)	`positionV2` is the same as `position` but it's for reanimated v2 api (a shared value instead of reanimated value).

Harbormaster completed remote builds in B33312: Diff 46769.Jan 22 2025, 3:18 AM

Closed by commit rCOMM84496cc2efe6: [native] Migrate containerStyle in CameraModal to functional component. · Explain WhyJan 22 2025, 5:39 PM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM84496cc2efe6: [native] Migrate containerStyle in CameraModal to functional component.

Revision Contents
Changeset List

Path

Size

native/

media/

camera-modal.react.js

31 lines

Diff 46802

native/media/camera-modal.react.js

Loading...