[lib] Create a migration function
ClosedPublic
Actions

Authored by tomek on Mon, Mar 17, 7:13 AM.

Details

Reviewers

kamil
bartek

Commits

rCOMM4ea52ae68c18: [lib] Create a migration function

Summary

This function should be used during migrations. An example is described in the test plan.

Depends on D14457

Test Plan

Tested the whole stack on both native and web:

Run the app on Redux version 86 with a modification to processDMOperation making all the INBOUND messages unsupported
On one platform created a thread and sent a text message. These were visible on the sender, and invisible on the recipient
Closed the recipient and added a migration that unshimms the thread creation operations, e.g.

unshimDMOperations(
  state,
  dmOperationTypes.CREATE_THREAD,
  handleReduxMigrationFailure,
): MigrationFunction<WebNavInfo, AppState>),

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Harbormaster returned this revision to the author for changes because remote builds failed.Mon, Mar 17, 7:52 AM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Mar 18, 4:09 AM

tomek requested review of this revision.Tue, Mar 18, 4:21 AM

kamil requested changes to this revision.Tue, Mar 18, 9:16 AM

kamil added inline comments.

lib/shared/unshim-utils.js
70 ↗	(On Diff #47450)	I don't see a reason for this to be optional. If I recall correctly, it was optionall in e.g. `unshimClientDB` because we wanted to handle both new migration and migrations before `handleMigrationFailure` was implemented.
107 ↗	(On Diff #47450)	there is no `cookie` in the state, each keyserver from `KeyserverStore` should have its own cookie