Page MenuHomePhabricator

[native] Add DMOperation operations to the C++ layer
ClosedPublic

Authored by tomek on Mon, Mar 17, 6:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 8:25 AM
Unknown Object (File)
Mon, Mar 17, 8:25 AM
Unknown Object (File)
Mon, Mar 17, 8:23 AM
Unknown Object (File)
Mon, Mar 17, 8:18 AM
Subscribers

Details

Summary

Handle the DB operations on the C++ layer.

https://linear.app/comm/issue/ENG-10330/create-db-operations

Depends on D14447

Test Plan

Tested the whole stack on both native and web:

  1. Run the app on Redux version 86 with a modification to processDMOperation making all the INBOUND messages unsupported
  2. On one platform created a thread and sent a text message. These were visible on the sender, and invisible on the recipient
  3. Closed the recipient and added a migration that unshimms the thread creation operations, e.g.
unshimDMOperations(
  state,
  dmOperationTypes.CREATE_THREAD,
  handleReduxMigrationFailure,
): MigrationFunction<WebNavInfo, AppState>),
  1. Run the recipient and noticed the thread appearing
  2. Added another migration, this time unshimming text messages
  3. Run the recipient and noticed messages appearing

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mon, Mar 17, 7:05 AM
Harbormaster failed remote builds in B33724: Diff 47413!
tomek requested review of this revision.Mon, Mar 17, 8:21 AM
This revision is now accepted and ready to land.Tue, Mar 18, 7:34 AM