Page MenuHomePhabricator
Differential D14449

[native][web] Expose new store to the JS layer
ClosedPublic
Actions

Authored by tomek on Mon, Mar 17, 6:53 AM.

Details

Reviewers
kamil
bartek
Commits
rCOMM5a3d21073c3e: [native][web] Expose new store to the JS layer
Summary

JSI and shared worker code that allows calling the operations from JS.

Depends on D14448

https://linear.app/comm/issue/ENG-10334/update-jsi-and-web-worker-code-to-support-new-db-operations

Test Plan

Tested the whole stack on both native and web:

  1. Run the app on Redux version 86 with a modification to processDMOperation making all the INBOUND messages unsupported
  2. On one platform created a thread and sent a text message. These were visible on the sender, and invisible on the recipient
  3. Closed the recipient and added a migration that unshimms the thread creation operations, e.g.
unshimDMOperations(
  state,
  dmOperationTypes.CREATE_THREAD,
  handleReduxMigrationFailure,
): MigrationFunction<WebNavInfo, AppState>),
  1. Run the recipient and noticed the thread appearing
  2. Added another migration, this time unshimming text messages
  3. Run the recipient and noticed messages appearing

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Mon, Mar 17, 6:53 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMon, Mar 17, 6:53 AM
tomek added a child revision: D14450: [web] Add SQLite query executor tests.Mon, Mar 17, 6:55 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Mon, Mar 17, 7:09 AM
Harbormaster failed remote builds in B33725: Diff 47414!
tomek updated this revision to Diff 47427.Mon, Mar 17, 7:26 AM

Update WASM

Harbormaster completed remote builds in B33737: Diff 47427.Mon, Mar 17, 8:02 AM
tomek requested review of this revision.Mon, Mar 17, 8:02 AM
kamil accepted this revision.Tue, Mar 18, 7:40 AM
kamil added inline comments.
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
196 ↗(On Diff #47427)

interesting that clang reformated this

This revision is now accepted and ready to land.Tue, Mar 18, 7:40 AM
tomek updated this revision to Diff 47455.Wed, Mar 19, 5:28 AM

Update WASM

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
196 ↗(On Diff #47427)

Yeah, it's strange, but the code remains correct

Harbormaster completed remote builds in B33763: Diff 47455.Wed, Mar 19, 5:46 AM
Closed by commit rCOMM5a3d21073c3e: [native][web] Expose new store to the JS layer (authored by tomek). · Explain WhyWed, Mar 19, 9:56 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM5a3d21073c3e: [native][web] Expose new store to the JS layer.

Revision Contents
Changeset List

PathSize
lib/
ops/
46 lines
types/
8 lines
native/
cpp/
CommonCpp/
NativeModules/
4 lines
251 lines
_generated/
schema/
2 lines
web/
cpp/
9 lines
shared-worker/
_generated/
types/
7 lines
worker/
1 line

Diff 47465

View Options

lib/ops/dm-operations-store-ops.js

Loading...
View Options

lib/types/store-ops-types.js

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...
View Options

web/shared-worker/worker/process-operations.js

Loading...