Page MenuHomePhabricator
Differential D14570

[SQLite][native] introduce `SQLiteUtils` class
ClosedPublic
Actions

Authored by kamil on Fri, Apr 11, 5:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 4:40 PM
Unknown Object (File)
Sat, Apr 19, 2:21 PM
Unknown Object (File)
Fri, Apr 18, 11:32 PM
Unknown Object (File)
Fri, Apr 18, 11:17 AM
Unknown Object (File)
Thu, Apr 17, 3:39 PM
Unknown Object (File)
Thu, Apr 17, 10:23 AM
Unknown Object (File)
Thu, Apr 17, 2:06 AM
Unknown Object (File)
Wed, Apr 16, 11:45 PM
View All 15 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMMa325ca34beae: [SQLite][native] introduce `SQLiteUtils` class
Summary

There are some utility stateless functions in SQLiteQueryExecutor, that are used in various methods. This makes it impossible to move them (methods that use utilities) out of SQLiteQueryExecutor.

Because of this change here, we'll have more flexibility and we'll make things cleaner.

ENG-10538.

Test Plan

Build native app, just moving code around

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Fri, Apr 11, 5:33 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Apr 11, 5:33 AM
kamil edited the summary of this revision. (Show Details)Fri, Apr 11, 5:34 AM
kamil mentioned this in D14571: [CommCoreModule][SQLite] remove unused JSI calls.Fri, Apr 11, 5:51 AM
Harbormaster completed remote builds in B33967: Diff 47752.Fri, Apr 11, 5:51 AM
kamil added a child revision: D14571: [CommCoreModule][SQLite] remove unused JSI calls.Fri, Apr 11, 6:54 AM
kamil edited the summary of this revision. (Show Details)Fri, Apr 11, 7:58 AM
kamil published this revision for review.Fri, Apr 11, 8:03 AM
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteUtils.cpp
86–169 ↗(On Diff #47752)

I am considering removing at least some part of this, as this was introduced long ago to migrate to the encrypted database, and I am not sure if we still need it. It was introduced in D2874 years ago

native/cpp/CommonCpp/DatabaseManagers/SQLiteUtils.h
9–28 ↗(On Diff #47752)

This class should only do some validation, encryption, and file and PRAGMA management, not sure if this is worth documenting.

kamil mentioned this in D14572: [SQLite] move database version getter and setter to `SQLiteUtils`.Fri, Apr 11, 8:18 AM
tomek accepted this revision.Mon, Apr 14, 1:35 AM
tomek added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteUtils.cpp
86–169 ↗(On Diff #47752)

I think it doesn't hurt to keep it. If we have to maintain this code then removing it might be a good idea.

This revision is now accepted and ready to land.Mon, Apr 14, 1:35 AM
Closed by commit rCOMMa325ca34beae: [SQLite][native] introduce `SQLiteUtils` class (authored by kamil). · Explain WhyMon, Apr 14, 3:12 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMa325ca34beae: [SQLite][native] introduce `SQLiteUtils` class.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
2 lines
200 lines
30 lines
171 lines
ios/
Comm.xcodeproj/
6 lines
web/
cpp/
1 line

Diff 47762

View Options

native/cpp/CommonCpp/DatabaseManagers/CMakeLists.txt

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines OlmPersistSession persistSession = {
it->first, it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()), std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version}; it->second.version};
this->storeOlmPersistSession(persistSession); this->storeOlmPersistSession(persistSession);
} }
} }
void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}
void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}
void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const { void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID); this->setMetadata("current_user_id", userID);
} }
std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const { std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id"); return this->getMetadata("current_user_id");
} }
▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines OlmPersistSession persistSession = {
it->first, it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()), std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version}; it->second.version};
this->storeOlmPersistSession(persistSession); this->storeOlmPersistSession(persistSession);
} }
} }
void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}
void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}
void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const { void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID); this->setMetadata("current_user_id", userID);
} }
std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const { std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id"); return this->getMetadata("current_user_id");
} }
▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteUtils.h

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines OlmPersistSession persistSession = {
it->first, it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()), std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version}; it->second.version};
this->storeOlmPersistSession(persistSession); this->storeOlmPersistSession(persistSession);
} }
} }
void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}
void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}
void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const { void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID); this->setMetadata("current_user_id", userID);
} }
std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const { std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id"); return this->getMetadata("current_user_id");
} }
▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteUtils.cpp

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines OlmPersistSession persistSession = {
it->first, it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()), std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version}; it->second.version};
this->storeOlmPersistSession(persistSession); this->storeOlmPersistSession(persistSession);
} }
} }
void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}
void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}
void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const { void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID); this->setMetadata("current_user_id", userID);
} }
std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const { std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id"); return this->getMetadata("current_user_id");
} }
▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines OlmPersistSession persistSession = {
it->first, it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()), std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version}; it->second.version};
this->storeOlmPersistSession(persistSession); this->storeOlmPersistSession(persistSession);
} }
} }
void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}
void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}
void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const { void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID); this->setMetadata("current_user_id", userID);
} }
std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const { std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id"); return this->getMetadata("current_user_id");
} }
▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...