Page MenuHomePhabricator
Differential D14571

[CommCoreModule][SQLite] remove unused JSI calls
ClosedPublic
Actions

Authored by kamil on Fri, Apr 11, 5:51 AM.
Tags
None
Referenced Files
F6090396: D14571.id.diff
Mon, Apr 21, 1:28 AM
Unknown Object (File)
Sun, Apr 20, 12:25 AM
Unknown Object (File)
Sat, Apr 19, 11:01 PM
Unknown Object (File)
Fri, Apr 18, 11:30 PM
Unknown Object (File)
Fri, Apr 18, 7:25 AM
Unknown Object (File)
Thu, Apr 17, 5:36 AM
Unknown Object (File)
Wed, Apr 16, 2:57 PM
Unknown Object (File)
Wed, Apr 16, 2:56 PM
View All 10 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMMa21b52612cb8: [CommCoreModule][SQLite] remove unused JSI calls
Summary

There are some calls that are unused now and won't be in the future. Removing them to avoid unnecessary maintenance of dead code.

ENG-10539

Depends on D14570

Test Plan

Build native app

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Fri, Apr 11, 5:51 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Apr 11, 5:51 AM
Harbormaster completed remote builds in B33968: Diff 47753.Fri, Apr 11, 6:08 AM
kamil edited the summary of this revision. (Show Details)Fri, Apr 11, 6:54 AM
kamil added a parent revision: D14570: [SQLite][native] introduce `SQLiteUtils` class.
kamil edited the summary of this revision. (Show Details)Fri, Apr 11, 8:04 AM
kamil published this revision for review.Fri, Apr 11, 8:07 AM
kamil added inline comments.
native/schema/CommCoreModuleSchema.js
39–43 ↗(On Diff #47753)

we have ops for it now

146–147 ↗(On Diff #47753)

No need to store Notif device token in SQLite

160 ↗(On Diff #47753)

This is called as part of clearSensitiveData

161–162 ↗(On Diff #47753)

We should use setCommServicesAuthMetadata and getCommServicesAuthMetadata to handle all auth metadata at once

kamil added a child revision: D14572: [SQLite] move database version getter and setter to `SQLiteUtils`.Fri, Apr 11, 8:09 AM
tomek accepted this revision.Mon, Apr 14, 1:37 AM
This revision is now accepted and ready to land.Mon, Apr 14, 1:37 AM
Closed by commit rCOMMa21b52612cb8: [CommCoreModule][SQLite] remove unused JSI calls (authored by kamil). · Explain WhyMon, Apr 14, 3:12 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMa21b52612cb8: [CommCoreModule][SQLite] remove unused JSI calls.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
2 lines
2 lines
8 lines
NativeModules/
12 lines
182 lines
_generated/
schema/
8 lines
web/
shared-worker/
_generated/

Diff 47764

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...