Page MenuHomePhabricator
Differential D14572

[SQLite] move database version getter and setter to `SQLiteUtils`
ClosedPublic
Actions

Authored by kamil on Fri, Apr 11, 8:09 AM.
Tags
None
Referenced Files
F6072115: D14572.id.diff
Sun, Apr 20, 1:45 PM
Unknown Object (File)
Fri, Apr 18, 4:16 PM
Unknown Object (File)
Fri, Apr 18, 9:51 AM
Unknown Object (File)
Fri, Apr 18, 12:16 AM
Unknown Object (File)
Thu, Apr 17, 1:09 PM
Unknown Object (File)
Thu, Apr 17, 10:28 AM
Unknown Object (File)
Thu, Apr 17, 1:00 AM
Unknown Object (File)
Wed, Apr 16, 3:24 PM
View All 17 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM935928a8f9e4: [SQLite] move database version getter and setter to `SQLiteUtils`
Summary

In the next diff, we want to call this from different files.

Part of ENG-10540

Depends on D14571

Test Plan

Build native app, just moving code around

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Fri, Apr 11, 8:09 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Apr 11, 8:09 AM
kamil added a child revision: D14573: [SQLite] implement `SQLiteSchema` class to wrap creation and migration logic.Fri, Apr 11, 8:10 AM
kamil published this revision for review.Fri, Apr 11, 8:18 AM
kamil edited the summary of this revision. (Show Details)
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteUtils.cpp
12–42 ↗(On Diff #47755)

As said in https://phab.comm.dev/D14570#inline-80723 - this class should do simple things and manage PRAGMA so I think this should be the right place for it

Harbormaster completed remote builds in B33969: Diff 47755.Fri, Apr 11, 8:28 AM
tomek accepted this revision.Mon, Apr 14, 1:38 AM
This revision is now accepted and ready to land.Mon, Apr 14, 1:38 AM
Closed by commit rCOMM935928a8f9e4: [SQLite] move database version getter and setter to `SQLiteUtils` (authored by kamil). · Explain WhyMon, Apr 14, 3:12 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM935928a8f9e4: [SQLite] move database version getter and setter to `SQLiteUtils`.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
48 lines
2 lines
32 lines

Diff 47763

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

  • This file was added.
// @flow
import reduceKeyserverStore from './keyserver-reducer.js';
import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js';
import { defaultKeyserverInfo } from '../types/keyserver-types.js';
describe('reduceKeyserverStore', () => {
it('removes from the store keyservers the user has disconnected from', () => {
const oldKeyserverStore = {
keyserverInfos: {
['0']: defaultKeyserverInfo('url1'),
['100']: defaultKeyserverInfo('url2'),
['200']: defaultKeyserverInfo('url3'),
},
};
const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success,
payload: {
currentUserInfo: { anonymous: true },
preRequestUserState: {
cookiesAndSessions: {},
currentUserInfo: {
id: '1000',
username: 'test',
},
},
keyserverIDs: ['100', '200'],
},
loadingInfo: {
fetchIndex: 1,
trackMultipleRequests: false,
customKeyName: undefined,
},
};
expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction),
).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } });
});
});
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteUtils.h

  • This file was added.
// @flow
import reduceKeyserverStore from './keyserver-reducer.js';
import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js';
import { defaultKeyserverInfo } from '../types/keyserver-types.js';
describe('reduceKeyserverStore', () => {
it('removes from the store keyservers the user has disconnected from', () => {
const oldKeyserverStore = {
keyserverInfos: {
['0']: defaultKeyserverInfo('url1'),
['100']: defaultKeyserverInfo('url2'),
['200']: defaultKeyserverInfo('url3'),
},
};
const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success,
payload: {
currentUserInfo: { anonymous: true },
preRequestUserState: {
cookiesAndSessions: {},
currentUserInfo: {
id: '1000',
username: 'test',
},
},
keyserverIDs: ['100', '200'],
},
loadingInfo: {
fetchIndex: 1,
trackMultipleRequests: false,
customKeyName: undefined,
},
};
expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction),
).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } });
});
});
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteUtils.cpp

  • This file was added.
// @flow
import reduceKeyserverStore from './keyserver-reducer.js';
import { deleteKeyserverAccountActionTypes } from '../actions/user-actions.js';
import { defaultKeyserverInfo } from '../types/keyserver-types.js';
describe('reduceKeyserverStore', () => {
it('removes from the store keyservers the user has disconnected from', () => {
const oldKeyserverStore = {
keyserverInfos: {
['0']: defaultKeyserverInfo('url1'),
['100']: defaultKeyserverInfo('url2'),
['200']: defaultKeyserverInfo('url3'),
},
};
const deleteAccountAction = {
type: deleteKeyserverAccountActionTypes.success,
payload: {
currentUserInfo: { anonymous: true },
preRequestUserState: {
cookiesAndSessions: {},
currentUserInfo: {
id: '1000',
username: 'test',
},
},
keyserverIDs: ['100', '200'],
},
loadingInfo: {
fetchIndex: 1,
trackMultipleRequests: false,
customKeyName: undefined,
},
};
expect(
reduceKeyserverStore(oldKeyserverStore, deleteAccountAction),
).toEqual({ keyserverInfos: { ['0']: defaultKeyserverInfo('url1') } });
});
});