[lib] fix `threadActivityStore` assertion code
ClosedPublic
Actions

Authored by kamil on May 5 2025, 2:23 PM.

Details

Reviewers

tomek
bartek

Commits

rCOMMe61fdb63a998: [lib] fix `threadActivityStore` assertion code

Summary

Context in ENG-10671.

onStateDifference was never passed to this reducer, which means even if the ops logic has a bug, we never saw any alert connected to this, as it was silenced.

Depends on D14650

Test Plan

Simulate state difference and make sure Alert is presented on native

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 5 2025, 2:23 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 5 2025, 2:23 PM

kamil retitled this revision from [lib] use `threadActivityStore` from SQLite to [lib] fix `threadActivityStore` assertion code.May 5 2025, 2:24 PM

Harbormaster completed remote builds in B34086: Diff 47944.May 5 2025, 2:47 PM

kamil published this revision for review.May 5 2025, 3:30 PM

kamil added inline comments.May 5 2025, 3:38 PM

lib/reducers/master-reducer.js
191 ↗	(On Diff #47944)

update

kamil added a child revision: D14653: [lib][web][native] remove `onStateDifference` implementation and use config.May 5 2025, 3:40 PM

Harbormaster completed remote builds in B34088: Diff 47946.May 5 2025, 4:35 PM

bartek accepted this revision.May 6 2025, 8:31 AM

This revision is now accepted and ready to land.May 6 2025, 8:31 AM

Closed by commit rCOMMe61fdb63a998: [lib] fix `threadActivityStore` assertion code. · Explain WhyMay 8 2025, 8:36 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMe61fdb63a998: [lib] fix `threadActivityStore` assertion code.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

master-reducer.js

6 lines

Diff 47962

View Options

lib/reducers/master-reducer.js

[lib] fix `threadActivityStore` assertion codeClosedPublicActions