Paths

Table of Contentst

[lib][web][native] remove `onStateDifference` implementation and use config
ClosedPublic
Actions

Authored by kamil on May 5 2025, 3:40 PM.

Details

Reviewers

tomek
bartek

Commits

rCOMM42abc24dd400: [lib][web][native] remove `onStateDifference` implementation and use config

Summary

It is better and simpler to use showAlert from config

Depends on D14651

Test Plan

Simulate state difference and make sure Alert is presented

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 5 2025, 3:40 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 5 2025, 3:40 PM

Harbormaster completed remote builds in B34089: Diff 47947.May 5 2025, 4:38 PM

kamil published this revision for review.May 5 2025, 4:55 PM

kamil added a child revision: D14655: [web] wait with `callGetInitialReduxState` until SQLite state is loaded.May 5 2025, 4:59 PM

bartek accepted this revision.May 6 2025, 8:31 AM

This revision is now accepted and ready to land.May 6 2025, 8:31 AM

Closed by commit rCOMM42abc24dd400: [lib][web][native] remove `onStateDifference` implementation and use config. · Explain WhyMay 8 2025, 8:36 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM42abc24dd400: [lib][web][native] remove `onStateDifference` implementation and use config.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

master-reducer.js

4 lines

native/

redux/

redux-debug-utils.js

redux-setup.js

7 lines

web/

redux/

redux-debug-utils.js

redux-setup.js

3 lines

Diff 47963

View Options

lib/reducers/master-reducer.js

View Options

native/redux/redux-debug-utils.js

View Options

native/redux/redux-setup.js

View Options

web/redux/redux-debug-utils.js

View Options

[lib][web][native] remove `onStateDifference` implementation and use configClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47963

lib/reducers/master-reducer.js

native/redux/redux-debug-utils.js

native/redux/redux-setup.js

web/redux/redux-debug-utils.js

web/redux/redux-setup.js

[lib][web][native] remove `onStateDifference` implementation and use config
ClosedPublic
Actions

Revision Contents
Changeset List