Differential D14775

[native] Handle Tonic gPRC network errors
ClosedPublic
Actions

Authored by bartek on May 28 2025, 9:06 AM.

Details

Reviewers

kamil

Commits

rCOMM280659d8d495: [native] Handle Tonic gPRC network errors

Summary

Part of ENG-10797
For Rust Tonic client, we just need to translate tonic::transport::Error into network_error

Test Plan

Make Identity Service unreachable (by disabling internet connection or using wrong URL)
Observe error message in console, it should be network_error

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 28 2025, 9:06 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 28 2025, 9:06 AM

bartek added a child revision: D14776: [backup-client] Handle reqwest network errors.May 28 2025, 9:09 AM

bartek mentioned this in D14777: [web] Handle grpc-web network errors.May 28 2025, 9:11 AM

Harbormaster completed remote builds in B34294: Diff 48292.May 28 2025, 9:24 AM

bartek published this revision for review.May 28 2025, 10:17 AM

kamil accepted this revision.May 28 2025, 2:13 PM

This revision is now accepted and ready to land.May 28 2025, 2:13 PM

Closed by commit rCOMM280659d8d495: [native] Handle Tonic gPRC network errors. · Explain WhyMay 29 2025, 8:41 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM280659d8d495: [native] Handle Tonic gPRC network errors.

bartek mentioned this in rCOMMcc1ecabf91be: [web] Handle grpc-web network errors.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

lib.rs

2 lines

shared/

grpc_clients/

src/

error.rs

9 lines

Diff 48333

View Options

native/native_rust_library/src/lib.rs