[web] Handle grpc-web network errors
ClosedPublic
Actions

Authored by bartek on May 28 2025, 9:11 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMMcc1ecabf91be: [web] Handle grpc-web network errors

Summary

Web part of ENG-10797.
Unfortunately, grpc-web error handling is a bit cryptic (I had to read the library code) so we have to use a little hacky solution here.

Depends on D14776

Test Plan

Same as D14775 but for web

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 28 2025, 9:11 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMay 28 2025, 9:11 AM

bartek added a child revision: D14778: [native] Display network error alert during restore flow.May 28 2025, 9:15 AM

Harbormaster failed remote builds in B34297: Diff 48295!May 28 2025, 9:23 AM

Rebase

bartek edited the test plan for this revision. (Show Details)May 28 2025, 10:13 AM

bartek attached a referenced file: F7998607: Screenshot 2025-05-28 at 10.36.28.png. (Show Details)

bartek published this revision for review.May 28 2025, 10:20 AM

bartek added inline comments.

web/grpc/identity-service-context-provider.react.js
107–111 ↗	(On Diff #48311)	Exact lines where these are set: timeout, xhr error. This isn't perfect but there's no other easy way here

Harbormaster completed remote builds in B34301: Diff 48311.May 28 2025, 10:26 AM

kamil accepted this revision.May 28 2025, 2:22 PM

kamil added inline comments.

web/grpc/identity-service-context-provider.react.js
107–111 ↗	(On Diff #48311)	Error handling in grpc-web is strange, thanks for linking code

This revision is now accepted and ready to land.May 28 2025, 2:22 PM

Closed by commit rCOMMcc1ecabf91be: [web] Handle grpc-web network errors. · Explain WhyMay 29 2025, 8:41 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMcc1ecabf91be: [web] Handle grpc-web network errors.

Revision Contents
Changeset List

Path

Size

web/

grpc/

identity-service-context-provider.react.js

8 lines

Diff 48335

View Options

web/grpc/identity-service-context-provider.react.js

[web] Handle grpc-web network errorsClosedPublicActions