Differential D14776

[backup-client] Handle reqwest network errors
ClosedPublic
Actions

Authored by bartek on May 28 2025, 9:09 AM.

Details

Reviewers

kamil

Commits

rCOMM7501e47fe51a: [backup-client] Handle reqwest network errors

Summary

ENG-10798
Similiar to D14775. Reqwest has its own APIs to detect this type of errors

Depends on D14775

Test Plan

Make Backup Service unreachable (by disabling internet connection or using wrong URL)
Try performing backup or restore. Observe error message in console, it should be network_error

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 28 2025, 9:09 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 28 2025, 9:09 AM

bartek added a child revision: D14777: [web] Handle grpc-web network errors.May 28 2025, 9:11 AM

Harbormaster failed remote builds in B34296: Diff 48294!May 28 2025, 9:21 AM

Fix wasm which doesnt support is_connect

Harbormaster completed remote builds in B34300: Diff 48298.May 28 2025, 10:16 AM

bartek published this revision for review.May 28 2025, 10:18 AM

kamil accepted this revision.May 28 2025, 2:17 PM

This revision is now accepted and ready to land.May 28 2025, 2:17 PM

Closed by commit rCOMM7501e47fe51a: [backup-client] Handle reqwest network errors. · Explain WhyMay 29 2025, 8:41 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM7501e47fe51a: [backup-client] Handle reqwest network errors.

Revision Contents
Changeset List

Path

Size

shared/

backup_client/

src/

lib.rs

20 lines

Diff 48334

View Options

shared/backup_client/src/lib.rs

[backup-client] Handle reqwest network errorsClosedPublicActions