Paths

Table of Contentst

Differential D14893

[lib] refactor holders reducer to ops pattern
ClosedPublic
Actions

Authored by kamil on Jul 3 2025, 3:31 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

tomek
bartek

Commits

rCOMMeede3b69b620: [lib] refactor holders reducer to ops pattern

Summary

Depends on D14892

Test Plan

Run holder tests

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 3 2025, 3:31 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 3 2025, 3:31 PM

kamil added a child revision: D14894: [native] implement C++ ops for holders.Jul 3 2025, 3:32 PM

Harbormaster completed remote builds in B34498: Diff 48635.Jul 3 2025, 4:05 PM

kamil published this revision for review.Jul 3 2025, 4:33 PM

bartek accepted this revision.Jul 7 2025, 11:20 AM

This revision is now accepted and ready to land.Jul 7 2025, 11:20 AM

bartek added inline comments.Jul 7 2025, 11:27 AM

lib/ops/holder-store-ops.js
89 ↗	(On Diff #48635)	Generally it's plural
lib/reducers/holder-reducer.js
115 ↗	(On Diff #48635)	Is it worth creating a similiar helper to `createReplaceHolderOperation`?

address review

Harbormaster completed remote builds in B34516: Diff 48655.Jul 9 2025, 11:47 AM

Closed by commit rCOMMeede3b69b620: [lib] refactor holders reducer to ops pattern. · Explain WhyJul 9 2025, 12:35 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMeede3b69b620: [lib] refactor holders reducer to ops pattern.

Revision Contents
Changeset List

Path

Size

lib/

ops/

holder-store-ops.js

11 lines

reducers/

holder-reducer.js

112 lines

holder-reducer.test.js

16 lines

master-reducer.js

4 lines

Diff 48664

lib/ops/holder-store-ops.js

Loading...

lib/reducers/holder-reducer.js

Loading...

lib/reducers/holder-reducer.test.js

Loading...

lib/reducers/master-reducer.js

Loading...