Differential D14907

[lib][web][native] implement SQLiteAPI method to get holders
ClosedPublic
Actions

Authored by kamil on Jul 9 2025, 3:35 PM.

Details

Reviewers

bartek

Commits

rCOMM2fab07c7c5cf: [lib][web][native] implement SQLiteAPI method to get holders

Summary

ENG-10448.

We don't want to read entire store when assigning new holders to reduce performance.

Depends on D14906

Test Plan

Test plan described in ENG-10446#comment-24db6b87.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 9 2025, 3:35 PM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 9 2025, 3:35 PM

kamil added a child revision: D14908: [lib] create holders after restoring.Jul 9 2025, 3:39 PM

Harbormaster completed remote builds in B34522: Diff 48672.Jul 9 2025, 3:54 PM

update

kamil published this revision for review.Jul 9 2025, 4:03 PM

Harbormaster completed remote builds in B34524: Diff 48674.Jul 9 2025, 4:23 PM

bartek accepted this revision.Jul 11 2025, 6:58 AM

This revision is now accepted and ready to land.Jul 11 2025, 6:58 AM

Closed by commit rCOMM2fab07c7c5cf: [lib][web][native] implement SQLiteAPI method to get holders. · Explain WhyJul 14 2025, 11:49 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM2fab07c7c5cf: [lib][web][native] implement SQLiteAPI method to get holders.

Revision Contents
Changeset List

Path

Size

lib/

types/

sqlite-types.js

2 lines

utils/

__mocks__/

config.js

1 line

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.h

1 line

CommCoreModule.cpp

36 lines

_generated/

commJSI-generated.cpp

commJSI.h

database/

sqlite-api.js

7 lines

schema/

CommCoreModuleSchema.js

2 lines

web/

database/

sqlite-api.js

15 lines

shared-worker/

worker/

shared-worker.js

16 lines

types/

worker-types.js

19 lines

Diff 48709

View Options

lib/types/sqlite-types.js

View Options

lib/utils/mocks/config.js

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI.h

View Options

native/database/sqlite-api.js

View Options

native/schema/CommCoreModuleSchema.js

View Options

web/database/sqlite-api.js

View Options

web/shared-worker/worker/shared-worker.js

View Options

[lib][web][native] implement SQLiteAPI method to get holdersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48709

lib/types/sqlite-types.js

lib/utils/__mocks__/config.js

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

native/cpp/CommonCpp/_generated/commJSI.h

native/database/sqlite-api.js

native/schema/CommCoreModuleSchema.js

web/database/sqlite-api.js

web/shared-worker/worker/shared-worker.js

web/types/worker-types.js

[lib][web][native] implement SQLiteAPI method to get holders
ClosedPublic
Actions

Revision Contents
Changeset List

lib/utils/mocks/config.js