Paths

Table of Contentst

Differential D14906

[native] get attachments during compaction and log upload based on holders table
ClosedPublic
Actions

Authored by kamil on Jul 9 2025, 2:55 PM.

Details

Reviewers

bartek

Commits

rCOMM49b3e1216c16: [native] get attachments during compaction and log upload based on holders table

Summary

ENG-10448.

Depends on D14905

Test Plan

Test plan described in ENG-10446#comment-24db6b87.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 9 2025, 2:55 PM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 9 2025, 2:55 PM

Harbormaster completed remote builds in B34521: Diff 48671.Jul 9 2025, 3:13 PM

kamil added a child revision: D14907: [lib][web][native] implement SQLiteAPI method to get holders.Jul 9 2025, 3:35 PM

kamil published this revision for review.Jul 9 2025, 4:03 PM

bartek accepted this revision.Jul 10 2025, 8:15 AM

bartek added inline comments.

native/cpp/CommonCpp/DatabaseManagers/NativeSQLiteConnectionManager.cpp
154 ↗	(On Diff #48671)	Should the index be extracted to a constant?

This revision is now accepted and ready to land.Jul 10 2025, 8:15 AM

kamil added inline comments.Jul 14 2025, 10:44 AM

native/cpp/CommonCpp/DatabaseManagers/NativeSQLiteConnectionManager.cpp
154 ↗	(On Diff #48671)	Previously it wasn't, and in the case of `sqlite3` API we use hardcoded constant in a lot of places

Closed by commit rCOMM49b3e1216c16: [native] get attachments during compaction and log upload based on holders table. · Explain WhyJul 14 2025, 11:49 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM49b3e1216c16: [native] get attachments during compaction and log upload based on holders table.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseManager.cpp

14 lines

NativeSQLiteConnectionManager.cpp

24 lines

SQLiteUtils.h

1 line

SQLiteUtils.cpp

9 lines

Diff 48708

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp

View Options

native/cpp/CommonCpp/DatabaseManagers/NativeSQLiteConnectionManager.cpp

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteUtils.h

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteUtils.cpp

[native] get attachments during compaction and log upload based on holders tableClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48708

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp

native/cpp/CommonCpp/DatabaseManagers/NativeSQLiteConnectionManager.cpp

native/cpp/CommonCpp/DatabaseManagers/SQLiteUtils.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteUtils.cpp

[native] get attachments during compaction and log upload based on holders table
ClosedPublic
Actions

Revision Contents
Changeset List