Paths

Table of Contentst

Differential D14921

[lib] Add actions to force set restoration state
ClosedPublic
Actions

Authored by bartek on Jul 11 2025, 10:00 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM9b6d6b0b27e9: [lib] Add actions to force set restoration state

Summary

Added two actions:

To reset restoration state - used when going to try restore flow again
To mark restoration as completed - when user agrees to continue without data being fully restored

Test Plan

Tested later in the stack.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jul 11 2025, 10:00 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 11 2025, 10:00 AM

Harbormaster failed remote builds in B34539: Diff 48698!Jul 11 2025, 10:18 AM

Rebase

Harbormaster completed remote builds in B34544: Diff 48703.Jul 11 2025, 10:56 AM

bartek published this revision for review.Jul 11 2025, 11:05 AM

bartek added inline comments.

lib/reducers/backup-reducer.js
79 ↗	(On Diff #48698)	I haven't found a usecase yet but we might consider adding something like `forced: true` to indicate that the data is incomplete, e.g. to prevent creating new compaction, cc @kamil

kamil accepted this revision.Jul 16 2025, 8:58 AM

kamil added inline comments.

lib/actions/backup-actions.js
28 ↗	(On Diff #48703)	typo
lib/reducers/backup-reducer.js
81–83 ↗	(On Diff #48703)	I would combine it like in all other reducers
79 ↗	(On Diff #48698)	Agree on this, makes sense

This revision is now accepted and ready to land.Jul 16 2025, 8:58 AM

Add 'forced' state, make types readonly

bartek added a child revision: D14944: [web] Add logic to restore error screen buttons.Jul 17 2025, 12:48 PM

Harbormaster completed remote builds in B34585: Diff 48768.Jul 17 2025, 1:02 PM

Closed by commit rCOMM9b6d6b0b27e9: [lib] Add actions to force set restoration state. · Explain WhyJul 18 2025, 10:26 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM9b6d6b0b27e9: [lib] Add actions to force set restoration state.

Revision Contents
Changeset List

Path

Size

lib/

actions/

backup-actions.js

5 lines

reducers/

backup-reducer.js

20 lines

types/

backup-types.js

54 lines

8 lines

Diff 48784

lib/actions/backup-actions.js

Loading...

lib/reducers/backup-reducer.js

Loading...

lib/types/backup-types.js

Loading...

lib/types/redux-types.js

Loading...