Differential D14934

[lib] Update AuxUserStore peers after restoring
ClosedPublic
Actions

Authored by bartek on Jul 16 2025, 12:59 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM9d56b6999251: [lib] Update AuxUserStore peers after restoring

Summary

Depends on D14933

Test Plan

Log in as user A, have user B in friend list. Create backup and primary logout.
Log in as user B, make any change to the device list (even primary login).
Restore user A, compare user B's device list in AuxUserStore

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jul 16 2025, 12:59 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 16 2025, 12:59 PM

Harbormaster completed remote builds in B34572: Diff 48744.Jul 16 2025, 1:17 PM

Rebase

Harbormaster failed remote builds in B34583: Diff 48766!Jul 17 2025, 10:41 AM

Rebase

Harbormaster completed remote builds in B34765: Diff 48970.Jul 24 2025, 7:20 AM

Rebase

Harbormaster failed remote builds in B34802: Diff 49009!Jul 24 2025, 4:02 PM

Rebase again

Harbormaster completed remote builds in B34980: Diff 49187.Jul 25 2025, 9:09 AM

bartek added a child revision: D15138: [lib] Broadcast device list update after restoration.Jul 25 2025, 9:24 AM

bartek published this revision for review.Jul 25 2025, 9:48 AM

kamil accepted this revision.Jul 28 2025, 8:35 AM

kamil added inline comments.

lib/backup/use-user-data-utils.js
69–72 ↗	(On Diff #49187)	I theory, this might fail because of missing auth metadata, but @bartek is preparing diff for this
lib/backup/user-data-restore-context.js
81–84 ↗	(On Diff #49187)	I think you need to update this line too

This revision is now accepted and ready to land.Jul 28 2025, 8:35 AM

bartek removed a child revision: D15138: [lib] Broadcast device list update after restoration.Jul 28 2025, 1:18 PM

Update startStepIndex

Harbormaster failed remote builds in B35014: Diff 49228!Jul 28 2025, 1:25 PM

bartek added a child revision: D15146: [lib][native][web] Add a way to override Identity AuthMetadata.Jul 29 2025, 9:18 AM

bartek added inline comments.Aug 6 2025, 8:30 AM

lib/backup/use-user-data-utils.js
69–72 ↗	(On Diff #49187)	Yes, this is addressed separately in D15146 to make sure it never fails
lib/backup/user-data-restore-context.js
81–84 ↗	(On Diff #49187)	Yes, thanks

This revision was landed with ongoing or failed builds.Aug 6 2025, 11:54 AM

Closed by commit rCOMM9d56b6999251: [lib] Update AuxUserStore peers after restoring. · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM9d56b6999251: [lib] Update AuxUserStore peers after restoring.

Revision Contents
Changeset List

Path

Size

lib/

backup/

use-user-data-restore.js

92 lines

reducers/

backup-reducer.js

1 line

types/

backup-types.js

1 line

Diff 48766

lib/backup/use-user-data-restore.js

Loading...

lib/reducers/backup-reducer.js

Loading...

lib/types/backup-types.js

Loading...