Paths

Table of Contentst

Differential D14937

[lib] implement `BackupIsNewerError` class
ClosedPublic
Actions

Authored by kamil on Jul 16 2025, 1:56 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMMff184a806424: [lib] implement `BackupIsNewerError` class

Summary

This is a more convenient way of handling this. Additionally, we can store it in user_data_restore_failed payload.

This is going to be handy as part of ENG-10817, where we want to keep a modal that the app needs to be updated and preventing users from using the app.

Depends on D14936

Test Plan

Bump store version
Upload backup
Restore store version to lower
Build app & try to restore, alert should be visible. Additionally check state if proper error is stored

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 16 2025, 1:56 PM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 16 2025, 1:56 PM

kamil edited the summary of this revision. (Show Details)Jul 16 2025, 1:57 PM

kamil added a child revision: D14938: [lib] fix handling `user_data_restore_failed` action.Jul 16 2025, 2:00 PM

Harbormaster completed remote builds in B34575: Diff 48747.Jul 16 2025, 2:14 PM

kamil published this revision for review.Jul 16 2025, 2:34 PM

Nice! This is a very convenient pattern of providing additional error info

lib/utils/errors.js
69–74 ↗	(On Diff #48747)	We could possibly hardcode the `backup_is_newer` message, but I'm not sure if it's the right pattern.

This revision is now accepted and ready to land.Jul 16 2025, 2:59 PM

Closed by commit rCOMMff184a806424: [lib] implement `BackupIsNewerError` class. · Explain WhyJul 17 2025, 9:33 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMff184a806424: [lib] implement `BackupIsNewerError` class.

kamil mentioned this in D14925: [native] Navigate to error screen after restoration failure.Jul 17 2025, 10:21 AM

Revision Contents
Changeset List

Path

Size

lib/

backup/

restored-migrations.js

10 lines

use-user-data-restore.js

29 lines

utils/

16 lines

native/

account/

7 lines

utils/

qr-code-utils.js

7 lines

web/

utils/

qr-code-utils.js

7 lines

Diff 48756

lib/backup/restored-migrations.js

Loading...

lib/backup/use-user-data-restore.js

Loading...

lib/utils/errors.js

Loading...

native/account/restore.js

Loading...

native/utils/qr-code-utils.js

Loading...

web/utils/qr-code-utils.js

Loading...