Paths

Table of Contentst

Differential D14942

[lib][web][native] implement handler to trigger restore
ClosedPublic
Actions

Authored by kamil on Jul 16 2025, 2:18 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM5b5bb0a69a41: [lib][web][native] implement handler to trigger restore

Summary

Depends on D14941

Test Plan

Bump store version
Upload backup
Revert the store version to a lower
Build app & try to restore, alert should be visible (for now).
Update the app - it gets restored automatically, and data is visible.

Restore
Kill the app in the middle
Open app, restore is resumed

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 16 2025, 2:18 PM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 16 2025, 2:18 PM

kamil edited the test plan for this revision. (Show Details)Jul 16 2025, 2:19 PM

kamil mentioned this in D14941: [native] initialize restored query executor.

kamil mentioned this in D14940: [web] initialize restored query executor.

kamil mentioned this in D14938: [lib] fix handling `user_data_restore_failed` action.

kamil published this revision for review.Jul 16 2025, 2:36 PM

kamil edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B34581: Diff 48753.Jul 16 2025, 2:52 PM

As we discussed offline, this should work okay.
There was a risk that the handler could be triggered when restoration had started from outside the handler, when user_data_restore_step_completed was set for a short while. However, if that happened, invariants in the restoration reducer should have been triggered, but such a thing didn't happen when testing this.

lib/backup/use-user-data-restore.js
130 ↗	(On Diff #48753)	typo

This revision is now accepted and ready to land.Jul 17 2025, 8:51 AM

kamil mentioned this in rCOMMd377073cfd80: [lib] fix handling `user_data_restore_failed` action.Jul 17 2025, 9:33 AM

kamil mentioned this in rCOMM8a22d9e6a167: [web] initialize restored query executor.

kamil mentioned this in rCOMMcd20f49d29c2: [native] initialize restored query executor.

kamil added a child revision: D14946: [native] update UserData upload conditions.Jul 17 2025, 2:09 PM

fix typo

Harbormaster completed remote builds in B34597: Diff 48790.Jul 18 2025, 11:22 AM

Closed by commit rCOMM5b5bb0a69a41: [lib][web][native] implement handler to trigger restore. · Explain WhyJul 18 2025, 12:01 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM5b5bb0a69a41: [lib][web][native] implement handler to trigger restore.

Revision Contents
Changeset List

Path

Size

lib/

backup/

use-user-data-restore.js

16 lines

handlers/

restore-backup-handler.react.js

35 lines

native/

2 lines

web/

2 lines

Diff 48792

lib/backup/use-user-data-restore.js

Loading...

lib/handlers/restore-backup-handler.react.js

Loading...

native/root.react.js

Loading...

web/app.react.js

Loading...