Paths

Table of Contentst

Differential D14941

[native] initialize restored query executor
ClosedPublic
Actions

Authored by kamil on Jul 16 2025, 2:11 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMMcd20f49d29c2: [native] initialize restored query executor

Summary

Depends on D14940

Test Plan

Tested in D14942

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 16 2025, 2:11 PM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 16 2025, 2:11 PM

remove logs

kamil added a child revision: D14942: [lib][web][native] implement handler to trigger restore.Jul 16 2025, 2:18 PM

kamil edited the test plan for this revision. (Show Details)Jul 16 2025, 2:20 PM

kamil published this revision for review.Jul 16 2025, 2:35 PM

Harbormaster completed remote builds in B34579: Diff 48751.Jul 16 2025, 2:35 PM

Harbormaster completed remote builds in B34580: Diff 48752.Jul 16 2025, 2:47 PM

bartek accepted this revision.Jul 17 2025, 9:12 AM

This revision is now accepted and ready to land.Jul 17 2025, 9:12 AM

bartek added inline comments.Jul 17 2025, 9:32 AM

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp
56 ↗	(On Diff #48752)	Not sure what would be the most accurate message here, but the previous one was somehow misleading, since we're about to initialize `restoredConnectionManager` a few lines below

Closed by commit rCOMMcd20f49d29c2: [native] initialize restored query executor. · Explain WhyJul 17 2025, 9:33 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMcd20f49d29c2: [native] initialize restored query executor.

kamil added a child revision: D14943: [native] update error message in `DatabaseManager::getQueryExecutor`.Jul 17 2025, 9:41 AM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseManager.cpp

19 lines

Diff 48760

native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp

Loading...