Paths

Table of Contentst

Differential D15179

[tunnelbroker] refactor notif code from `WebsocketSession` to a separate module
ClosedPublic
Actions

Authored by kamil on Aug 8 2025, 8:45 AM.

Details

Reviewers

bartek

Commits

rCOMM0fb6d5b13652: [tunnelbroker] refactor notif code from `WebsocketSession` to a separate module

Summary

ENG-10869.

Cleaning up mixed responsibilities in WebsocketSession. Make it more maintainable before adding farcaster support

Depends on D15178

Test Plan

commtest, aftre deploying to staging I am going to test notfis

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 8 2025, 8:45 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 8 2025, 8:45 AM

kamil added a child revision: D15180: [tunnelbroker] factor out `NotifClient` creation from `main.rs`.Aug 8 2025, 8:48 AM

Harbormaster completed remote builds in B35063: Diff 49314.Aug 8 2025, 9:02 AM

kamil published this revision for review.Aug 8 2025, 12:02 PM

bartek accepted this revision.Aug 11 2025, 9:49 AM

bartek added inline comments.

services/tunnelbroker/src/notifs/mod.rs
57–71 ↗	(On Diff #49314)	`#[derive(derive_more::Constructor)]` could generate this for you, but this also ok

This revision is now accepted and ready to land.Aug 11 2025, 9:49 AM

Closed by commit rCOMM0fb6d5b13652: [tunnelbroker] refactor notif code from `WebsocketSession` to a separate module. · Explain WhyAug 11 2025, 11:38 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM0fb6d5b13652: [tunnelbroker] refactor notif code from `WebsocketSession` to a separate module.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

main.rs

8 lines

notifs/

mod.rs

358 lines

websockets/

session.rs

293 lines

Diff 49505

View Options

services/tunnelbroker/src/main.rs

View Options

services/tunnelbroker/src/notifs/mod.rs

View Options

services/tunnelbroker/src/websockets/session.rs

[tunnelbroker] refactor notif code from `WebsocketSession` to a separate moduleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49505

services/tunnelbroker/src/main.rs

services/tunnelbroker/src/notifs/mod.rs

services/tunnelbroker/src/websockets/session.rs

[tunnelbroker] refactor notif code from `WebsocketSession` to a separate module
ClosedPublic
Actions

Revision Contents
Changeset List