Introduce two new thread types and a new, unique ID schema for the Farcaster threads.
https://linear.app/comm/issue/ENG-10944/create-new-thread-types
Details
Details
Tests
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- farcaster3
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/utils/validation-utils.js | ||
|---|---|---|
| 122 ↗ | (On Diff #49320) | We have to wrap it with additional parentheses, because otherwise the regex would become farcasterID|something, which then, inside idSchemaRegExp becomes ^farcasterID|something$ which is buggy, because the engine tries to match ^farcasterID or something$. |
| lib/utils/validation-utils.js | ||
|---|---|---|
| 117 | Not sure if we should use only hexes here or alphanumeric values, worth confirming | |
Comment Actions
Make the validation less strict
| lib/utils/validation-utils.js | ||
|---|---|---|
| 117 | Yeah, I guess it doesn't hurt to make the validation less strict | |