Differential D15189

[lib] Facaster MVP
AbandonedPublic
Actions

Authored by kamil on Aug 11 2025, 10:37 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

bartek
tomek

Summary

This is not planned to be landed, just overall idea for now. MIght change after what is said here.

Depends on D15188

Test Plan

Tested using some local tests (with mocked DC token and user ID), it was also tested with client changes in the actual app, example here.

Diff Detail

Repository

Branch

publish-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Aug 11 2025, 10:37 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 11 2025, 10:37 AM

kamil added inline comments.Aug 11 2025, 10:50 AM

lib/shared/farcaster/farcaster-message-types.js
67–70	The types here are what I reverse-engineered based on responses, but it is hard to predict and implement conversion for all message types. This is also tricky when it comes to validators to make clients resistant for API changes (avoid crashing when there will be message with different type)

Harbormaster completed remote builds in B35249: Diff 49500.Aug 11 2025, 10:55 AM

ashoat added inline comments.Aug 11 2025, 1:54 PM

lib/shared/farcaster/farcaster-message-types.js
67–70	For the Farcaster APIs, we should probably be lax about validation to avoid crashes. I'll follow up on types in ENG-11089

Publishing to get some initial feedback, but I need to update this before landing or at least create tasks (removing TODOs and hardcoded IDs)

kamil planned changes to this revision.Aug 13 2025, 2:39 PM

Deprecating in favour of D15201, D15203, and following diffs later in the stack

Revision Contents
Changeset List

Path

Size

lib/

hooks/

input-state-container-hooks.js

10 lines

shared/

farcaster/

farcaster-api.js

85 lines

farcaster-message-types.js

70 lines

message-utils.js

4 lines

threads/

protocols/

farcaster-thread-protocol.js

139 lines

12 lines

Diff 49500

lib/hooks/input-state-container-hooks.js

Loading...

lib/shared/farcaster/farcaster-api.js

Loading...

lib/shared/farcaster/farcaster-message-types.js

Loading...

lib/shared/message-utils.js

Loading...

lib/shared/threads/protocols/farcaster-thread-protocol.js

Loading...

lib/shared/threads/thread-spec.js

Loading...