Add a conversion including a mapping between the permissions systems
https://linear.app/comm/issue/ENG-10944/create-new-thread-types
Depends on D15200
Details
Details
Flow
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
LGTM, but I have no expertise in the permission system
| lib/permissions/farcaster-permissions.js | ||
|---|---|---|
| 33 ↗ | (On Diff #49563) | If onlyAdminsCanWrite is set, the member is not able to leave the thread? |
| lib/utils/farcaster-utils.js | ||
| 359 ↗ | (On Diff #49563) | Are you sure this will work for threads, not only for users? I was initialy thinking of ClientImageAvatar here, but I might be wrong |
Comment Actions
Correctly handle removed users
| lib/permissions/farcaster-permissions.js | ||
|---|---|---|
| 33 ↗ | (On Diff #49563) | Good point! I don't know how it works on the Farcaster side, as I didn't see this option in the UI, but I assume users can leave. |
| lib/utils/farcaster-utils.js | ||
| 359 ↗ | (On Diff #49563) | Probably won't work at this point, but I'll make sure to test and fix it later in the stack |